fix: fixed/improved handling of app names in api #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to improve and fix the handling of app names particularly in create and update APIs. It rids of spaces from the input JSON and replaces them with
-.Reasoning
In the UI, spaces are not allowed when inputting the app name but its not the same using the API as it inserts it as is.
This resulted to a bug I encountered when trying to deploy a compose service. The deployment failed due to an unknown command error as Dokploy tries to execute this command which is obviously invalid:
║ App Name: hello world ║ Build Compose 🐳 ║ Detected: 0 mounts 📂 ║ Command: docker compose -p hello world -f docker-compose.yml up -d ║ --build --remove-orphans ║ Source Type: docker raw ✅ ║ Compose Type: docker-compose ✅ ... unknown docker command: "compose hello"