Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to delete docker volumes on service deletion #886

Merged

Conversation

DJKnaeckebrot
Copy link
Contributor

@DJKnaeckebrot DJKnaeckebrot commented Dec 14, 2024

This pull request introduces a new feature that allows users to delete volumes associated with a compose when deleting the compose itself. The changes span across multiple files to implement this functionality.

Key changes include:

Frontend Changes:

Backend Changes:

Pending Changes

  • Redis DB
  • Postgres DB
  • Mysql DB
  • Mongo DB
  • Application

@Siumauricio
Copy link
Contributor

I think this only applies to docker compose

@DJKnaeckebrot
Copy link
Contributor Author

I think this only applies to docker compose

Kinda, I was thinking about making a query that goes through the volumes and deletes the ones that have the same name than the app you want to delete. It's a bit hacky but might do the job.

Copy link
Contributor

@Siumauricio Siumauricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@DJKnaeckebrot DJKnaeckebrot marked this pull request as ready for review December 23, 2024 07:40
@DJKnaeckebrot
Copy link
Contributor Author

I dont know why but I just saw that the PR i made for the biomejs settings somehow did not ended in the canary branch :c

I'll revise to avoid having this many liniting issues. Also saw on a different PR that formating marked 4k+ lines as new :D

@DJKnaeckebrot
Copy link
Contributor Author

Or maybe an idea would be to use sth like husky pre commit hooks ?

@Siumauricio Siumauricio merged commit 96cdffb into Dokploy:canary Dec 23, 2024
2 checks passed
@Siumauricio Siumauricio mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants