Feat: Classic UI option - #53
Draft
rhrlima wants to merge 3 commits into
Draft
Conversation
- UI Style swap in option menu - PlayerInfo window - MainMenu window - UiManagerV2 initial design - Temp changes to work with existing setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to Issue #52
This PR adds an option to "Classic" UI themed windows.
It uses components and scripts that I put into an Unity Package called RO Flex UI, which is a collection of modular prefabs and scripts that should simplify the way we build UI in general, not only with the classic style.
What Changed?
PlayerInfo and MainMenu windows
I did only these two windows for now as simpler examples that do not require complex behavior.
PlayerInfois the top-left window that displays Player's information like Name, Job, HP/SP, exp, etc.MainMenuis the Escape window that usually shows options for character selection and keybindings, but here I added buttons for the same options we have at the bottom.I had to rework a little bit of
CharacterDetailBoxandPlayerStateand use an Observer pattern to update the old and new UI windows based on changes to the Player data. I believe this can be expanded and added to other parts of the code as well, to simplify how we handle controller and view scripts.UiManagerV2
Follows the same basic idea from the current script with a dictionary of windows for management, and a list of openwindows, to control what to close.
It also proposes a self-register pattern, where the Window script can call during
Start()something like:Which should simplify how we register windows, and possibly handle keyboard events.
Example
Working Player Info window

Examples of Classic Windows built using the components
