This PR adds the possibility of doing a direct import instead of file copies - #24
Draft
Mamotromico wants to merge 54 commits into
Draft
This PR adds the possibility of doing a direct import instead of file copies#24Mamotromico wants to merge 54 commits into
Mamotromico wants to merge 54 commits into
Conversation
Should probably revise this later on
It can still be used on file copy, but doing the import proccess directly speeds up a bit and saves space
Needs further work, when trying to use this during the import proccess it breaks sprite sounds import
Mamotromico
force-pushed
the
import_revision
branch
2 times, most recently
from
August 21, 2025 15:17
f94933b to
6fe681c
Compare
Prefer explicity typing Unify translation strings into a single structure Rever private prefix, clean up comments, prefer explicit typing Revert some typing changes to reduce diff More diff reduction Remove spaces Reduce diff by removing unrelated changes Reduce diff info Cleanup on diff Remove unused import Remove jetbrains annotation Additional reverts
Ideally this will be merged with RagnarokCopyFromRealClient and just deal with menus and batch file copies, whenever proper support for ro file formats roll on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a revision/proposal on changes to the import process and code. It also fixes an issue present on the "Select data to copy from client data folder" option that was breaking the dialog rendering, making it unusable without doing an initial copy through other means.
This is a draft for now since there are still things to do, right now the sprite import is breaking when having to deal with sounds. Working on that now.
But simpler act/spr importing can already be tested.
Some of intended goals: