Bugfix - send action on destroy + memory leaks #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
bugfix/send-action-on-destroy
branch
from
f3a3e81
to
e299cfa
Compare
snewcomer
force-pushed
the
bugfix/send-action-on-destroy
branch
from
64595c5
to
14a4325
Compare
snewcomer
force-pushed
the
bugfix/send-action-on-destroy
branch
from
1c0c1e5
to
397cc15
Compare
snewcomer
commented
Mar 30, 2018
| @@ -20,7 +20,6 @@ module('Acceptance | infinity-scrollable', function(hooks) { | |||
| await waitFor('.infinity-scrollable.inactive'); | |||
|
|
|||
| assert.equal(findAll('.infinity-svg').length, 20); | |||
| assert.equal(findAll('.infinity-scrollable.inactive').length, 1, 'component is inactive after fetching more data'); | |||
There was a problem hiding this comment.
I think this is a race condition. For one, this fails randomly on diff builds. Second, it wouldn't proceed from the await waitFor unless it didn't find it as inactive.
Passes consistently locally; however, not up on CI.
snewcomer
changed the title
Closed
snewcomer
commented
Apr 6, 2018
| elem.addEventListener('scroll', () => { | ||
| this._debouncedEventHandler('_triggerDidScrollDirection', elem, sensitivity); | ||
| }); | ||
| this._debouncedEventHandler = this._debouncedEvent.bind(this, '_triggerDidScrollDirection', elem, sensitivity); |
There was a problem hiding this comment.
Another way I guess would be =>
this._debouncedEventClosure = (e => this._debouncedEventHandler('_triggerDidScrollDirection', elem, sensitivity));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to still send the action
didEnterViewport/didExitViewport(thanks Nathan H 🏅) even though the component is being torn down.seting state is simply around for the nextonIntersection, which makes it irrelevant in this context.close #141