Compact object #72
Compact object #72
Conversation
| typeOf, | ||
| A: emberArray | ||
| } = Ember; | ||
| const keys = Object.keys || Ember.keys; |
There was a problem hiding this comment.
We can kill Ember.keys, that is deprecated.
There was a problem hiding this comment.
It is; but doesn't 1.13 still support IE 8, which needs the Ember.keys polyfill?
spencer516
force-pushed
the
compact-object
branch
from
d2533b3
to
c84fd7f
Compare
|
^^ Did a bit of refactoring per your recommendations and got rid of that superfluous observer. |
|
☔ The latest upstream changes (presumably #74) made this pull request unmergeable. Please resolve the merge conflicts. |
spencer516
force-pushed
the
compact-object
branch
from
c84fd7f
to
2db2cb6
Compare
|
I rebased this as it got a bit stagnant. If y'all have any other feedback, let me know. |
|
If you rebase this against master, |
spencer516
force-pushed
the
compact-object
branch
from
2db2cb6
to
10da1db
Compare
| } = Ember; | ||
| const keys = Object.keys || Ember.keys; |
There was a problem hiding this comment.
This line is not needed, just use Object.keys.
|
☔ The latest upstream changes (presumably #122) made this pull request unmergeable. Please resolve the merge conflicts. |
JSCS Errors Fixes error on Ember 1.13 Use isPresent one liner guard for non-arrays Guard before setting the array support object compacting update readme guard for non-array/non-object values don't use array computed be explicit about not supporting changing keys don't use @each remove unnecessary observer use ember libs
spencer516
force-pushed
the
compact-object
branch
from
10da1db
to
85d7888
Compare
|
Sorry I hadn't touched this in a while — must have missed that comment from 15 days ago. |
|
Let's make this happen :) |
| Or: | ||
|
|
||
| ```hbs | ||
| {{#each-in (compacy objectWithBlanks) as |notBlankKey notBlankValue|}} |
|
☔ The latest upstream changes (presumably 4e9995f) made this pull request unmergeable. Please resolve the merge conflicts. |
|
We're not going to merge this, as compact cannot track object properties being added/removed, so it would lead to weird stuff happening updating the object after the helper has run once. |
ghost
closed this
This adds support to #64 for compacting objects.
FYI: Tests are failing on Beta/Canary due to this bug: emberjs/ember.js#12995