Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for CRA v5 #88

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

xyy94813
Copy link
Contributor

Resolve #86

@csulit
Copy link

csulit commented Dec 16, 2021

Waiting for this.

@xyy94813
Copy link
Contributor Author

Do I need to consider compatibility with both v4 and v5?

Or, if someone is using the new version in CRA v4, do I need to give some feedback?

@ihoey
Copy link

ihoey commented Dec 20, 2021

Waiting for this.

1 similar comment
@MyNameIsAlaa
Copy link

Waiting for this.

@tux-tn
Copy link
Collaborator

tux-tn commented Dec 21, 2021

Will check it and try to merge it today. Sorry for the delay guys 🙏

@xyy94813
Copy link
Contributor Author

It may not be necessary to use resolve-url-loader
bholloway/resolve-url-loader#200 (comment)

Copy link
Collaborator

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for your efforts @xyy94813

@tux-tn tux-tn merged commit 9b05de1 into DocSpring:master Dec 23, 2021
@tux-tn tux-tn mentioned this pull request Dec 24, 2021
@tux-tn
Copy link
Collaborator

tux-tn commented Dec 24, 2021

[email protected] is out with support for CRA 5. Thank you guys and sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find 'file-loader' issue with react-scripts 5.0.0
5 participants