Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0.0 detect obsndi #1045

Merged
merged 7 commits into from
Jul 30, 2024
Merged

6.0.0 detect obsndi #1045

merged 7 commits into from
Jul 30, 2024

Conversation

paulpv
Copy link
Member

@paulpv paulpv commented Jul 26, 2024 •
edited
Loading

Part 1.2 of 2: (yes, I am aware that does not make much sense! :))

  1. Detect if OBS-NDI is installed
  2. If OBS-NDI is not detected then proceed as normal
  3. If OBS-NDI is detected then
  4. Show a dialog to the user to uninstall OBS-NDI
  5. return false and tell OBS that DistroAV failed to load

@paulpv paulpv changed the base branch from master to 6.0.0_actual July 26, 2024 06:14
@paulpv paulpv self-assigned this Jul 27, 2024
@paulpv paulpv marked this pull request as ready for review July 27, 2024 11:33
@paulpv
Copy link
Member Author

paulpv commented Jul 27, 2024

Oh... I need to translate the new text.
Will do after I sleep. 😴

@paulpv
Copy link
Member Author

paulpv commented Jul 27, 2024

I lied; translations pushed.
G'night! 💤

@paulpv paulpv force-pushed the 6.0.0_actual branch 2 times, most recently from d4d5d19 to daa67de Compare July 30, 2024 03:03
@paulpv
Copy link
Member Author

paulpv commented Jul 30, 2024

No feedback on this; I am going to merge it to 6.0.0_actual #1050

@paulpv paulpv merged commit cb52932 into 6.0.0_actual Jul 30, 2024
6 checks passed
@paulpv paulpv deleted the 6.0.0_detect_obsndi branch July 30, 2024 03:11
@paulpv paulpv mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Palakis Palakis Awaiting requested review from Palakis

@Trouffman Trouffman Awaiting requested review from Trouffman

@RayneYoruka RayneYoruka Awaiting requested review from RayneYoruka

Assignees

@paulpv paulpv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulpv