Improve performance of RFECV visualizer #1048
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1047 which reported that yellowbrick's internal implementation of RFECV is much slower than scikit-learn's. This PR introduces a new implementation of
RFECV
that is closer to the latest version ofsklearn.RFECV
.I have made the following changes:
_RFECV
that subclasses the sklearn implementation and adds our required functionalitySample Code and Plot
If you are adding or modifying a visualizer, PLEASE include a sample plot here along with the code you used to generate it.
TODOs and questions
Still to do:
Questions for the @DistrictDataLabs/team-oz-maintainers:
@lwgray @rebeccabilbro and @jc639 -- it would be great if we could work on this together
CHECKLIST
pytest
?make html
?