Skip to content

Commit

Permalink
Fix Unrecognized command line option -msign-return-address=all
Browse files Browse the repository at this point in the history
Ticket: nodejs#42888
  • Loading branch information
sparist committed Aug 29, 2023
1 parent a48ef84 commit c257e69
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1289,10 +1289,11 @@ def configure_node(o):

o['variables']['want_separate_host_toolset'] = int(cross_compiling)

# Enable branch protection for arm64
if target_arch == 'arm64':
o['cflags']+=['-msign-return-address=all']
o['variables']['arm_fpu'] = options.arm_fpu or 'neon'
# See: https://github.com/nodejs/node/issues/42888
# # Enable branch protection for arm64
# if target_arch == 'arm64':
# o['cflags']+=['-msign-return-address=all']
# o['variables']['arm_fpu'] = options.arm_fpu or 'neon'

if options.node_snapshot_main is not None:
if options.shared:
Expand Down

0 comments on commit c257e69

Please sign in to comment.