Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/poetry: Add poetry build and publish process whenever a release is tagged #15

Merged
merged 24 commits into from
May 29, 2023

Conversation

Hamada-Distributed
Copy link
Contributor

This feature will enable us to finally publish python wheels when we tag a version for release. In particular, this will use poetry to build the pythonmonkey.so file and then will place this file into the appropriate python location for packaging by poetry.

Poetry will package it such that the file structure looks like this:
--> pythonmonkey
-----> __init__.py
-----> pythonmonkey.so

Tentatively, I've made __init__.py import all symbols from pythonmonkey.so. This should let one do the typical

import pythonmonkey as pm
pm.eval("()=>{ return 1; }")()

and it should just work.

pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
build.py Show resolved Hide resolved
build.py Show resolved Hide resolved
.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@Xmader Xmader self-requested a review May 26, 2023 22:18
@Hamada-Distributed Hamada-Distributed removed the request for review from zollqir May 29, 2023 14:06
.github/workflows/test-and-publish.yaml Outdated Show resolved Hide resolved
.github/workflows/test-and-publish.yaml Show resolved Hide resolved
Copy link
Member

@Xmader Xmader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants