Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(params): avoid calling signature() twice #1059

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

shiftinv
Copy link
Member

Summary

This is a microoptimization for application command signature parsing, passing down the inspect.Signature object through expand_params -> collect_params -> isolate_self, instead of computing a new signature object there.
Also avoids emitting warnings from within string annotations twice, as seen in #991 (comment).

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes t: bugfix skip news labels Jun 19, 2023
@shiftinv shiftinv added this to the disnake v2.9 milestone Jun 19, 2023
Co-authored-by: arl <[email protected]>
Signed-off-by: shiftinv <[email protected]>
@onerandomusername onerandomusername enabled auto-merge (squash) June 20, 2023 20:32
@onerandomusername onerandomusername merged commit dcc1b83 into master Jun 20, 2023
@onerandomusername onerandomusername deleted the fix/params-signature-twice branch June 20, 2023 20:36
@shiftinv shiftinv removed the s: needs review Issue/PR is awaiting reviews label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: bugfix t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants