Adjust GetSide to allow for multiple anchorable panes on the left or top #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the auto hide button is clicked for an anchorable window, the GetSide method determines the side it should use. The existing logic requires that it be the first child in order to go to the left side.
Our users are finding this behavior confusing. When they dock multiple anchorable windows side-by-side on the left, they expect all of them to go to the left side when clicking the auto hide. However, some of them will shift to the right. The following video shows this behavior in the TestApp:
GetSide-CurrentBehavior.mp4
This change expands the logic for determining the left (or top side) to include any anchorable pane that is at the beginning of the children collection, rather than just the first child. The following video shows the adjusted behavior in the TestApp:
GetSide-UpdatedBehavior.mp4