Skip to content

Commit

Permalink
ingress-nginx: list.extend returns None and breaks resource_deps (#18)
Browse files Browse the repository at this point in the history
Fix resource_deps parsing to allow arguments and default (helm chart repo) to be combined properly.

ingress-nginx: list.extend returns None and breaks expected behvior of resource_deps
  • Loading branch information
TimothyLoyer committed Jul 9, 2024
1 parent e3d46c4 commit 6f2186e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ingress_nginx/helm/Tiltfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ REPO_ALIAS = "ingress-nginx-repo"
LABEL = "ingress"

def load_helmchart(resource_deps = [], labels = []):
resource_deps.append(REPO_ALIAS)

helm_repo(
REPO_ALIAS,
url = "https://kubernetes.github.io/ingress-nginx",
Expand All @@ -20,6 +22,6 @@ def load_helmchart(resource_deps = [], labels = []):
"--set=controller.allowSnippetAnnotations=true",
"--set=controller.ingressClassResource.default=true",
],
resource_deps = [REPO_ALIAS].extend(resource_deps),
resource_deps = resource_deps,
labels = labels or [LABEL],
)

0 comments on commit 6f2186e

Please sign in to comment.