Fix CSS Grid "auto track" / placement bugs #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"negative implicit" tracks
…rids that contain negative implicit tracks.
TimJentzsch
approved these changes
May 17, 2023
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
* Fix divide by zero when using grid_auto_rows/grid_auto_columns with zero "negative implicit" tracks * Fix over-allocation in the CellOccupancyMatrix when auto-placing in grids that contain negative implicit tracks. * Fix axis conflation when grid_auto_flow is column * Fix computation of auto track offset when initializing negative implicit tracks * Add basic tests for grid_auto_rows and grid_auto_columns
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
* Fix divide by zero when using grid_auto_rows/grid_auto_columns with zero "negative implicit" tracks * Fix over-allocation in the CellOccupancyMatrix when auto-placing in grids that contain negative implicit tracks. * Fix axis conflation when grid_auto_flow is column * Fix computation of auto track offset when initializing negative implicit tracks * Add basic tests for grid_auto_rows and grid_auto_columns
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
* Fix divide by zero when using grid_auto_rows/grid_auto_columns with zero "negative implicit" tracks * Fix over-allocation in the CellOccupancyMatrix when auto-placing in grids that contain negative implicit tracks. * Fix axis conflation when grid_auto_flow is column * Fix computation of auto track offset when initializing negative implicit tracks * Add basic tests for grid_auto_rows and grid_auto_columns
nicoburns
added a commit
that referenced
this pull request
Aug 14, 2023
* Fix divide by zero when using grid_auto_rows/grid_auto_columns with zero "negative implicit" tracks * Fix over-allocation in the CellOccupancyMatrix when auto-placing in grids that contain negative implicit tracks. * Fix axis conflation when grid_auto_flow is column * Fix computation of auto track offset when initializing negative implicit tracks * Add basic tests for grid_auto_rows and grid_auto_columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix bugs in the CSS Grid track initialization and placement code
Changes made
Context
While testing Taffy with Blitz I hit a panic caused by a divide-by-zero when attempting to use the grid_auto_rows property. Investigating this led me to realise that Taffy has no tests testing grid_auto_rows and grid_auto_columns. Adding some basic tests for these properties revealed a number of bugs which have been fixed in this PR.
Notes
This should probably be backported to
0.3.xonce it lands inmain.