Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to_owned example in use_coroutine reference #271

Closed
wants to merge 1 commit into from
Closed

Fix to_owned example in use_coroutine reference #271

wants to merge 1 commit into from

Conversation

gmeir
Copy link

@gmeir gmeir commented May 9, 2024

missing the actual to_owned! call

@gmeir
Fix to_owned example in use_coroutine reference
d706c68 
missing the actual `to_owned!` call
ealmloff
ealmloff requested changes May 9, 2024
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer need to_owned to move signals into coroutines because they are copy. We should either remove the example or show to_owned with something that is not Copy

@jkelleyrtp jkelleyrtp closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmeir @ealmloff @jkelleyrtp