Honor subdir for hashless assets #4698
Open
+25
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohe2015
commented
Sep 26, 2025
| PathBuf::from(format!("{}-dxh{hash}", file_stem.to_string_lossy())) | ||
| } else { | ||
| PathBuf::from(file_stem) | ||
| PathBuf::from(asset.relative_source_path().trim_start_matches("/assets/")).with_extension("") |
There was a problem hiding this comment.
This is the main functional change
|
This design could have some odd behavior for relative assets. If I include You can control where assets are copied today by copying a folder into the asset dir, but it is more work to set up if you need to copy it into a deeply nested folder. // / wasm
// / myapp.wasm
asset!("/wasm").with_hash(false); // this will copy the wasm folder and all of its contents into the asset folderWhat do you think about a separate destination path option on the asset builder like this instead? asset!("../../asset.png").with_bundled_at("/my/wasm/folder/asset.png") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When combining multiple dioxus runs (for example web worker output with web application) it is helpful when the subdirectories are also honored for hashless assets so that the wasm imports from the
wasm/folder of the web worker is correctly found.I don't know if this is the best solution but maybe you have a better idea. Also at some places the correct relative path is not calculated.