Skip to content

Conversation

ealmloff
Copy link
Member

This PR addresses two pain points with stores:

  1. There is a bug with the index method on Store<Vec<T>>. The rest of the methods use the index directly as the selector index, but the .index method instead hashes the index. This can cause some items to not update correclty
  2. If you try to expose the index method through a wrapper method, you can't name the type returned from the index method. We have a concrete type already, but it wasn't re-exported. You need to name this type for the automatic Store<T, _> to Store<T> conversion to work on the component boundary

@ealmloff ealmloff requested a review from a team as a code owner September 23, 2025 16:56
@ealmloff ealmloff added bug Something isn't working breaking This is a breaking change stores labels Sep 23, 2025
@jkelleyrtp jkelleyrtp merged commit ecec70f into DioxusLabs:main Oct 4, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change bug Something isn't working stores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants