Check target compatibility before using the default renderer #4592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have a cargo.toml set up like this:
and serve with this command
dx serve --platform desktop
, dx will disable theweb
feature and enable thedesktop
feature flag because the renderer you selected was different than the defaultHowever, that doesn't work if you serve with
dx serve --destkop
which only sets the target, not the renderer. This PR makesdx serve --desktop
work by checking compatibility between the currently set target and the renderer. The implicit web renderer is not compatible with the explicitly set desktop target so dx disables the web renderer just like it does with--platform desktop