Escape characters on xml attributes #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt-jean-baptiste-lemee
force-pushed
the
escape-charaters-on-xml-attributes
branch
from
f47e99e to
3f63e45
Compare
dt-hugues-lerebours
left a comment
dt-hugues-lerebours
left a comment
There was a problem hiding this comment.
I have no idea if it's OK.
It looks oddly specific, though.
worker.js
Outdated
| }; | ||
|
|
||
| const QUOTE = /"/g; | ||
| const QUOTE$1 = /"/g; |
There was a problem hiding this comment.
Generated code... because it's defined 2 times in 2 different files... I could put it in some constants file yes
There was a problem hiding this comment.
ok I didn't know this was generated
dt-jean-baptiste-lemee
force-pushed
the
escape-charaters-on-xml-attributes
branch
from
ff91f91 to
3e2579b
Compare
dt-jean-baptiste-lemee
force-pushed
the
escape-charaters-on-xml-attributes
branch
from
3e2579b to
0ce8770
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal review
Issue on linkedom project : WebReflection#216
PR on linkedom: WebReflection#217
Waiting PR on Dilitrust : https://github.com/DiliTrust/hlx-service-web/pull/7601