Skip to content

Removing unneeded where clause from query and fixing a notice #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Removing unneeded where clause from query and fixing a notice #4

wants to merge 2 commits into from

Conversation

@Bakual
Copy link

@Bakual Bakual commented Mar 11, 2017

As written in Glip 😄

  • Removing the where clause for the fieldIds in the query as I think that is redundant
  • Fixing a notice

@laoneo
Copy link
Member

laoneo commented Mar 13, 2017

Closing this one as the context got removed in pr joomla#14558 completely.

@laoneo laoneo closed this Mar 13, 2017
@laoneo
Copy link
Member

laoneo commented Mar 13, 2017

Thanks anyway for your help!!

@Bakual Bakual deleted the CustomFieldsPerformance branch March 13, 2017 11:18
laoneo pushed a commit that referenced this pull request Jun 12, 2017
@frankmayer @rdeutz
Cleanups, fixes and a bit of optimizations for site/components batch #4…
778153e 
… (joomla#12293)

* Cleanups, fixes and a bit of optimizations for site/components batch #4

- com_mailto
- com_newsfeeds
- com_search

Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole

* Missed to convert `and` and `or`

* Some more fixes after conflict resolution

* - Changed some things according to reviewer's suggestions
- Some more changes in updated stuff

* Reversed a change according to reviewer's correct comment.
laoneo pushed a commit that referenced this pull request Oct 5, 2017
@dgrammatiko
Squashed commit of the following:
cf6854d 
commit f866778a5326b4e1c3db10f578ac48c43c66c653
Author: dgt41 <[email protected]>
Date:   Sat Sep 2 22:51:17 2017 +0300

    more changes

commit 4207db197419c8a098feb1d68ef07d2247301986
Author: dgt41 <[email protected]>
Date:   Sat Sep 2 19:03:35 2017 +0300

    fix the routing

commit ddb59ac
Author: dgt41 <[email protected]>
Date:   Fri Sep 1 16:12:38 2017 +0300

    fixes, remove webcomponets

commit 727401a
Merge: 1b1726d 6981a18
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Fri Sep 1 15:35:45 2017 +0300

    Merge pull request joomla#64 from ciar4n/style-postinstall

    Post install markup and style

commit 6981a18
Author: ciar4n <[email protected]>
Date:   Fri Sep 1 13:32:31 2017 +0100

    Post install markup and style

commit 1b1726d
Merge: 0a43128 42e5517
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue Aug 29 14:28:33 2017 +0300

    Merge pull request joomla#63 from ciar4n/style-preinstall

    New style to preinstall

commit 42e5517
Author: ciar4n <[email protected]>
Date:   Tue Aug 29 12:24:20 2017 +0100

    New style to preinstall check

commit 0a43128
Author: dgt41 <[email protected]>
Date:   Wed Aug 23 16:37:18 2017 +0300

    js fixes

commit 9974ee5
Merge: 8fb5939 48857fc
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue Aug 22 19:53:31 2017 +0300

    Merge pull request joomla#62 from ciar4n/install-style

    Install re design

commit 48857fc
Author: ciar4n <[email protected]>
Date:   Tue Aug 22 17:50:20 2017 +0100

    Redesign

commit 8fb5939
Author: dgt41 <[email protected]>
Date:   Sat Aug 19 18:24:35 2017 +0300

    remove duplicate line

commit 520b8d9
Author: dgt41 <[email protected]>
Date:   Sat Aug 19 18:06:42 2017 +0300

    unmute sessions

commit 8f18075
Merge: 7b04a78 020ad0e
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Fri Jul 21 14:04:08 2017 +0300

    Merge pull request joomla#60 from ciar4n/install-style1

    Various bits

commit 7b04a78
Author: dgt41 <[email protected]>
Date:   Fri Jul 21 13:42:13 2017 +0300

    clean up

commit 020ad0e
Author: ciar4n <[email protected]>
Date:   Fri Jul 21 11:24:58 2017 +0100

    Refactor alerts

commit 214db09
Author: dgt41 <[email protected]>
Date:   Fri Jul 21 13:19:13 2017 +0300

    core needs patching

commit 2b5e924
Author: ciar4n <[email protected]>
Date:   Fri Jul 21 10:58:35 2017 +0100

    Compile SCSS

commit 3ffa406
Author: ciar4n <[email protected]>
Date:   Fri Jul 21 10:58:05 2017 +0100

    Add view/default.php

commit b0a580d
Author: dgt41 <[email protected]>
Date:   Fri Jul 21 10:54:53 2017 +0300

    Use webcomponents for the alerts

commit 91272d2
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 20:53:07 2017 +0300

    easter egg, wow

commit a890a0b
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 19:45:12 2017 +0300

    do not fail

commit 00badb5
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 19:15:48 2017 +0300

    IIFE was a bad idea

commit 117426b
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 18:56:14 2017 +0300

    set focus to the rigth input between steps

commit 0df4e1b
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 18:44:59 2017 +0300

    smooth transitions in setup

commit 269d005
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 18:21:37 2017 +0300

    routing

commit 66b1cd7
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 15:28:20 2017 +0300

    better handling of the form

commit 8582cb6
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 14:39:05 2017 +0300

    recompile

commit e7135cf
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 14:24:36 2017 +0300

    session

commit 65bd548
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 14:08:10 2017 +0300

    styles

commit 2a41250
Author: dgt41 <[email protected]>
Date:   Wed Jul 19 21:34:38 2017 +0300

    cleanup

commit 45a8af0
Author: dgt41 <[email protected]>
Date:   Fri Jun 23 19:47:16 2017 +0300

    more

commit 405f799
Author: dgt41 <[email protected]>
Date:   Tue Jun 6 11:36:50 2017 +0300

    morrere

commit 4eb2ef5
Author: dgt41 <[email protected]>
Date:   Mon Jun 5 15:27:32 2017 +0300

    morerrererer

commit 6c3a285
Author: dgt41 <[email protected]>
Date:   Sun Jun 4 13:55:25 2017 +0300

    morrrerer

commit faaca17
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 19:53:18 2017 +0300

    NOOOOOOOOOOOOOOOOOOOOOOOOO

commit 3eec79d
Merge: 4a91d2a d81f374
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Sun Jun 4 12:56:23 2017 +0200

    Merge pull request joomla#58 from ciar4n/animate-form

    Animate that form - fix header

commit d81f374
Author: ciar4n <[email protected]>
Date:   Thu Jun 1 17:56:25 2017 +0100

    Animate that form

commit 4a91d2a
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 17:26:00 2017 +0300

    more

commit 09d0ce8
Merge: 98eadea b058ea6
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Thu Jun 1 14:57:39 2017 +0200

    Merge pull request joomla#57 from ciar4n/form-split

    Form split

commit b058ea6
Merge: 97c32b4 98eadea
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Thu Jun 1 14:57:28 2017 +0200

    Merge branch '################4.0-dev-installation' into form-split

commit 97c32b4
Author: ciar4n <[email protected]>
Date:   Thu Jun 1 13:53:20 2017 +0100

    Split form

commit 98eadea
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit 14aa21c
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit e70bd5e
Author: dgt41 <[email protected]>
Date:   Wed May 31 15:18:42 2017 +0300

    morrrrre

commit d38061a
Author: dgt41 <[email protected]>
Date:   Wed May 31 11:34:24 2017 +0300

    more

commit b3730b7
Merge: e95fb4a 8d41267
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Wed May 31 10:34:59 2017 +0200

    Merge pull request joomla#56 from ciar4n/post-install-ftp

    Post install ftp & lang select to header

commit 8d41267
Author: ciar4n <[email protected]>
Date:   Wed May 31 09:32:29 2017 +0100

    Move lang select to header

commit 6803dd0
Author: ciar4n <[email protected]>
Date:   Tue May 30 18:22:59 2017 +0100

    Post install FTP options

commit e95fb4a
Merge: e143c1a 7519981
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue May 30 17:00:42 2017 +0200

    Merge pull request joomla#55 from ciar4n/password-icon

    Remove header margin - add password icon

commit 7519981
Author: ciar4n <[email protected]>
Date:   Tue May 30 15:57:15 2017 +0100

    Remove header margin - add password icon

commit e143c1a
Author: dgt41 <[email protected]>
Date:   Tue May 30 17:24:48 2017 +0300

    preinstall

commit b8a55a7
Merge: a5213d6 1107db2
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue May 30 16:03:17 2017 +0200

    Merge pull request joomla#54 from ciar4n/install-style

    Installation layout and style

commit 1107db2
Author: ciar4n <[email protected]>
Date:   Tue May 30 14:58:16 2017 +0100

    install-style

commit a5213d6
Author: dgt41 <[email protected]>
Date:   Tue May 30 15:54:33 2017 +0300

    1 col

commit 9e85f1c
Author: dgt41 <[email protected]>
Date:   Tue May 30 13:11:34 2017 +0300

    markup

commit 55eebdc
Author: dgt41 <[email protected]>
Date:   Mon May 29 12:18:39 2017 +0300

    init
laoneo pushed a commit that referenced this pull request Oct 5, 2017
@dgrammatiko
Squashed commit of the following:
7a94090 
commit f866778a5326b4e1c3db10f578ac48c43c66c653
Author: dgt41 <[email protected]>
Date:   Sat Sep 2 22:51:17 2017 +0300

    more changes

commit 4207db197419c8a098feb1d68ef07d2247301986
Author: dgt41 <[email protected]>
Date:   Sat Sep 2 19:03:35 2017 +0300

    fix the routing

commit ddb59ac
Author: dgt41 <[email protected]>
Date:   Fri Sep 1 16:12:38 2017 +0300

    fixes, remove webcomponets

commit 727401a
Merge: 1b1726d 6981a18
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Fri Sep 1 15:35:45 2017 +0300

    Merge pull request joomla#64 from ciar4n/style-postinstall

    Post install markup and style

commit 6981a18
Author: ciar4n <[email protected]>
Date:   Fri Sep 1 13:32:31 2017 +0100

    Post install markup and style

commit 1b1726d
Merge: 0a43128 42e5517
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue Aug 29 14:28:33 2017 +0300

    Merge pull request joomla#63 from ciar4n/style-preinstall

    New style to preinstall

commit 42e5517
Author: ciar4n <[email protected]>
Date:   Tue Aug 29 12:24:20 2017 +0100

    New style to preinstall check

commit 0a43128
Author: dgt41 <[email protected]>
Date:   Wed Aug 23 16:37:18 2017 +0300

    js fixes

commit 9974ee5
Merge: 8fb5939 48857fc
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue Aug 22 19:53:31 2017 +0300

    Merge pull request joomla#62 from ciar4n/install-style

    Install re design

commit 48857fc
Author: ciar4n <[email protected]>
Date:   Tue Aug 22 17:50:20 2017 +0100

    Redesign

commit 8fb5939
Author: dgt41 <[email protected]>
Date:   Sat Aug 19 18:24:35 2017 +0300

    remove duplicate line

commit 520b8d9
Author: dgt41 <[email protected]>
Date:   Sat Aug 19 18:06:42 2017 +0300

    unmute sessions

commit 8f18075
Merge: 7b04a78 020ad0e
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Fri Jul 21 14:04:08 2017 +0300

    Merge pull request joomla#60 from ciar4n/install-style1

    Various bits

commit 7b04a78
Author: dgt41 <[email protected]>
Date:   Fri Jul 21 13:42:13 2017 +0300

    clean up

commit 020ad0e
Author: ciar4n <[email protected]>
Date:   Fri Jul 21 11:24:58 2017 +0100

    Refactor alerts

commit 214db09
Author: dgt41 <[email protected]>
Date:   Fri Jul 21 13:19:13 2017 +0300

    core needs patching

commit 2b5e924
Author: ciar4n <[email protected]>
Date:   Fri Jul 21 10:58:35 2017 +0100

    Compile SCSS

commit 3ffa406
Author: ciar4n <[email protected]>
Date:   Fri Jul 21 10:58:05 2017 +0100

    Add view/default.php

commit b0a580d
Author: dgt41 <[email protected]>
Date:   Fri Jul 21 10:54:53 2017 +0300

    Use webcomponents for the alerts

commit 91272d2
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 20:53:07 2017 +0300

    easter egg, wow

commit a890a0b
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 19:45:12 2017 +0300

    do not fail

commit 00badb5
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 19:15:48 2017 +0300

    IIFE was a bad idea

commit 117426b
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 18:56:14 2017 +0300

    set focus to the rigth input between steps

commit 0df4e1b
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 18:44:59 2017 +0300

    smooth transitions in setup

commit 269d005
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 18:21:37 2017 +0300

    routing

commit 66b1cd7
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 15:28:20 2017 +0300

    better handling of the form

commit 8582cb6
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 14:39:05 2017 +0300

    recompile

commit e7135cf
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 14:24:36 2017 +0300

    session

commit 65bd548
Author: dgt41 <[email protected]>
Date:   Thu Jul 20 14:08:10 2017 +0300

    styles

commit 2a41250
Author: dgt41 <[email protected]>
Date:   Wed Jul 19 21:34:38 2017 +0300

    cleanup

commit 45a8af0
Author: dgt41 <[email protected]>
Date:   Fri Jun 23 19:47:16 2017 +0300

    more

commit 405f799
Author: dgt41 <[email protected]>
Date:   Tue Jun 6 11:36:50 2017 +0300

    morrere

commit 4eb2ef5
Author: dgt41 <[email protected]>
Date:   Mon Jun 5 15:27:32 2017 +0300

    morerrererer

commit 6c3a285
Author: dgt41 <[email protected]>
Date:   Sun Jun 4 13:55:25 2017 +0300

    morrrerer

commit faaca17
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 19:53:18 2017 +0300

    NOOOOOOOOOOOOOOOOOOOOOOOOO

commit 3eec79d
Merge: 4a91d2a d81f374
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Sun Jun 4 12:56:23 2017 +0200

    Merge pull request joomla#58 from ciar4n/animate-form

    Animate that form - fix header

commit d81f374
Author: ciar4n <[email protected]>
Date:   Thu Jun 1 17:56:25 2017 +0100

    Animate that form

commit 4a91d2a
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 17:26:00 2017 +0300

    more

commit 09d0ce8
Merge: 98eadea b058ea6
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Thu Jun 1 14:57:39 2017 +0200

    Merge pull request joomla#57 from ciar4n/form-split

    Form split

commit b058ea6
Merge: 97c32b4 98eadea
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Thu Jun 1 14:57:28 2017 +0200

    Merge branch '################4.0-dev-installation' into form-split

commit 97c32b4
Author: ciar4n <[email protected]>
Date:   Thu Jun 1 13:53:20 2017 +0100

    Split form

commit 98eadea
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit 14aa21c
Author: dgt41 <[email protected]>
Date:   Thu Jun 1 12:28:16 2017 +0300

    more

commit e70bd5e
Author: dgt41 <[email protected]>
Date:   Wed May 31 15:18:42 2017 +0300

    morrrrre

commit d38061a
Author: dgt41 <[email protected]>
Date:   Wed May 31 11:34:24 2017 +0300

    more

commit b3730b7
Merge: e95fb4a 8d41267
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Wed May 31 10:34:59 2017 +0200

    Merge pull request joomla#56 from ciar4n/post-install-ftp

    Post install ftp & lang select to header

commit 8d41267
Author: ciar4n <[email protected]>
Date:   Wed May 31 09:32:29 2017 +0100

    Move lang select to header

commit 6803dd0
Author: ciar4n <[email protected]>
Date:   Tue May 30 18:22:59 2017 +0100

    Post install FTP options

commit e95fb4a
Merge: e143c1a 7519981
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue May 30 17:00:42 2017 +0200

    Merge pull request joomla#55 from ciar4n/password-icon

    Remove header margin - add password icon

commit 7519981
Author: ciar4n <[email protected]>
Date:   Tue May 30 15:57:15 2017 +0100

    Remove header margin - add password icon

commit e143c1a
Author: dgt41 <[email protected]>
Date:   Tue May 30 17:24:48 2017 +0300

    preinstall

commit b8a55a7
Merge: a5213d6 1107db2
Author: Dimitri Grammatikogianni <[email protected]>
Date:   Tue May 30 16:03:17 2017 +0200

    Merge pull request joomla#54 from ciar4n/install-style

    Installation layout and style

commit 1107db2
Author: ciar4n <[email protected]>
Date:   Tue May 30 14:58:16 2017 +0100

    install-style

commit a5213d6
Author: dgt41 <[email protected]>
Date:   Tue May 30 15:54:33 2017 +0300

    1 col

commit 9e85f1c
Author: dgt41 <[email protected]>
Date:   Tue May 30 13:11:34 2017 +0300

    markup

commit 55eebdc
Author: dgt41 <[email protected]>
Date:   Mon May 29 12:18:39 2017 +0300

    init
laoneo pushed a commit that referenced this pull request Sep 6, 2018
@anuragteapot @laoneo
[4.0][GSoC 2018] Improve Override Management (joomla#21851)
811ab3f 
* Load correct core files of override files (#2)

Start implements loadcorefile() in administrator/components/com_templates/Model/TemplateModel.php

* CS (#3) Coding Standards

* codingstandards

* codingstandards (#4)

* Test (#6)

Phase 2 (2 part) Mechanism to find correct core file and implementation.

* Remove Notice: Only available for html-folder

* Remove Warning if core file not found (#11)

Thanks.
So one part of the issue joomla-projects/gsoc18_override_management#12 is done.

* Implement the diff view in template manager 

Implement the diff view in template manager

* coding standard (#17)

* fix diff (#18) Fix bug in path in case of administrator template override.

Fix bug in path in case of administrator template override.

* Notification after update and TEST (#16)

Find changed files of overridden files and show message.

* coding standard (#21)

* correction

* correction (#26)

* Correcthtmlpath (#27)

* correction

* change oldhtml to newhtml

* List of updated override files. (#30)

* addcss (joomla#34)

* Final Product  (joomla#39)

Core and Diff view
Updated override history list.
Quick icon notification plugin.
Override control plugin.

* save 3 lines :)

* New feature show status. (joomla#47)

show status in com_template view templates

* link

* corrected namespace

* Button to Switch (joomla#35)

* wip add Switcher

* wip style switcher

* wip style switch make inline and change on off text

* wip start with js

* wip js

* wip delete buttons and make js more robust

* wip save to storage

* wip delete old code

* wip

* wip lint

* wip css

* set default value for switcher

* wip make switcher blue

* wip

* wip

* build

* correct names

* create new functions

* fist test code

* use onchange

* undo installer.min.js

* add forgotten new line at the end of css file

* correct align

* correct compare.es6 - only deleted the toggle part

* correct compare.js - only deleted the toggle part

* wip

* reduce timeout

* wrap in funcitons

* wip

* add use strict to both js-files(compare and toggle)

* add the timeout value of 500 again, because 200 are not enought in my case

* use css class 'active' for toggle views

* add strict

* time out for editor

* wip

* improvments use newActive and switch

* correction

* width of switcher-spans

* correct align

* do not use global

* wip

* removed timeouts

* JTEXT to TEXT

* forgotton last line

* deleted duplicated comments

* css fix align

* use unnamed functions in es6

* Sql files for fix database (joomla#50)

* sql files for database fix

* delete space

* Suggestion for displaying Dates in view updates files (joomla#52)

Correct Dates and do not use date of file any more

* Store Date as UTC and show it in server time zone (joomla#57)

* modified and created date are created and stored in UTC

* convert dates for displaying in model

* spar a loop

* normalize timezone in view

* use language constants for dateformat

* JToolbarHelper to ToolbarHelper

* CS

* namespace

* plural

* name

* clean

* text

* fx

* sin

* files

* s

* Suggestion for language strings (joomla#60)

* language strings

* correct typo

* delete media folder plg_quickicon

* add folder plg_quickicon to build/media_src

* delete files in media folder

* Move media folder - System (joomla#66)

* multi

* cs

* delete files in media folder for joomla toolbar (joomla#67)

* Fix button switchers style. (joomla#70)

* button

* CS

* changed uitab.addTab for updated files

* Bring back core.js changes. (joomla#69)

* core.js

* const

* fix

* form

* core

* hound

* CS

* scopr

* grid

* alpha

* cs

* lang

* only override file

* lang

* override lang installer

* Cs

* sub

* Update list of core extensions (joomla#71)

* Language changes (joomla#76)

* update

* Update en-GB.com_templates.ini

* override JLIB_HTML_PUBLISH_ITEM

this is the hover text on the publish icon in the list of files

* Change icon (joomla#74)

change the icon to use an outline for more consistency

* lang

* not core (joomla#75)

* not core

* Update en-GB.plg_installer_override.ini

* namespace

* cs

* Updated files (joomla#82)

* Update default_updated_files.php

* Update en-GB.com_templates.ini

* Update en-GB.com_templates.ini (joomla#81)

* Update en-GB.plg_quickicon_overridecheck.ini (joomla#80)

* Update en-GB.plg_quickicon_overridecheck.ini (joomla#79)

* remove space (joomla#78)

* Update en-GB.plg_quickicon_overridecheck.ini

* Update en-GB.plg_quickicon_overridecheck.sys.ini

* remove hardcoded id

* null get function

* state

* clean

* More changes "core" to "original" (joomla#85)

* cs

* update

* plural
laoneo pushed a commit that referenced this pull request Sep 26, 2018
@mbabker
Create possibility for nested subforms (joomla#17552)
f2a9874 
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message #6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message #7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message #8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bakual @laoneo