Skip to content

Remove double asset lock #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Remove double asset lock #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84b7de7
Remove double asset lock
bembelimen Jan 22, 2022
e29636e
Only remove lock
bembelimen Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions libraries/src/Table/Nested.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,17 +555,8 @@ public function delete($pk = null, $children = true)
/** @var Asset $asset */
$asset = Table::getInstance('Asset', 'JTable', array('dbo' => $this->getDbo()));

// Lock the table for writing.
if (!$asset->_lock())
{
// Error message set in lock method.
return false;
}

if ($asset->loadByName($name))
{
$asset->_unlock();

// Delete the node in assets table.
if (!$asset->delete(null, $children))
{
Expand All @@ -577,7 +568,6 @@ public function delete($pk = null, $children = true)
else
{
$this->setError($asset->getError());
$asset->_unlock();

return false;
}
Expand Down