Fix jquery::framework to use WebAsset, and add "defer=false" attribute#13
Fix jquery::framework to use WebAsset, and add "defer=false" attribute#13laoneo merged 2 commits intoDigital-Peak:j4/defer/jsfrom
Conversation
| { | ||
| "name": null, | ||
| "js": ["jquery.min.js"] | ||
| "js": ["jquery.min.js"], |
There was a problem hiding this comment.
Should we not do these kind of changes un its own pr in the main repo?
There was a problem hiding this comment.
that true, I even have plan to do it for whole jquery.php
but I have include it here, because without this your pull not work
There was a problem hiding this comment.
ah, no, sorry, I confused with settings.json
settings.json changes must be here, because we going to add attribute (defer:fase) to jquery.min.js, which already exist in settings.json
|
you can ignore changes for |
|
Actually the pr in the main repo dies work. What ia broken there? |
|
@laoneo just check how it work on latest 4.0-dev, you will see a looot "jQuery undefined" in browser console 😉 and undefined cssVars() |
|
Ah wait, sorry. I was in a total different pr joomla#23062. |
2 participants
This is fix/update for joomla#22460
Because
jquery::freamworknot always in use after WebAsset was introduced.