Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the compose and setup a little more automatic #134

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

ric866
Copy link

@ric866 ric866 commented Sep 23, 2024

Altered docker-compose.yml to clone this app into a python container and run a dirty custom command to launch.
Amended the setup.py to read environment vars which can be passed into the container at launch time.

@santiagosayshey
Copy link
Collaborator

Woah, thanks for the PR, this is great!

I'll give this a review when I can, just a bit busy with uni at the moment.

@richjdsmith
Copy link

richjdsmith commented Nov 22, 2024

Hey just checking to see if you were able to pull this in before I do it myself manually haha

@ric866
Copy link
Author

ric866 commented Nov 22, 2024

Hey just checking to see if you were able to pull this in before I do it myself manually haha

I couldn't, I'm not that privileged in this repo 😄
@santiagosayshey have you had chance to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants