Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Goble 03 vue1 #248

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Goble 03 vue1 #248

wants to merge 13 commits into from

Conversation

wpgoble
Copy link

@wpgoble wpgoble commented Jun 29, 2023

Pull Request Description

Addresses #10


Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

wpgoble and others added 13 commits June 29, 2023 10:00
…e#210)

* Initial commit, adding seeding input data cypress test

* subtask DickinsonCollege#1 Assert header has 'Data'

* Check the crop dropdown list size

* Testing crop dropdown

* Testing for crop dropdown length

* Testing for crop dropdown length

* test input date element enabled and has correct default value

* Cleaning cypress test

* Add spec.js file for testing seeding report columns by seeding type

* Add test column for Tray Seedings

* Completed testing for Direct Seeding column headers

* Added a test to check where proper columns are displayed in the table for "All" seeding type

* Reformat Tray Seeding test to look like Direct Seeding test format

* Rewrite the test for all option (checking the table columns) for better efficiency and readability

* Delete unnecessary folder

* Modify test for the table column for the all option. Specifically, modified the for loop that check the visibility of table headers to use cypress tag instead of using .children() for to get the header elements

* delete an unnecessary folder

* Standardized tests and addressed requested changes

* Cleaned comments

* Address PR change requests

* Add test for Edit header back

* Check for report table before checkbuttons and add check that the checkbuttons are not disabled

---------

Co-authored-by: nathang15 <[email protected]>
Co-authored-by: infantlikesprogramming <[email protected]>
Copy link
Member

@braughtg braughtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a final comment

<p>Title:<input type="text" value="My Sample Harvest Report"></p>
<p>Start: <input type="date" id="start_date" name="season-start" value="2020-05-05" min="2014-01-01" max="2022-01-01"/>
End: <input type="date" id="end_date" name="season-end" value="2020-05-15" min="2020-05-05" max="2022-01-01" /> </p>
<p>Crop:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment.

<option selected>Kale</option>
<option>Peas</option>
</select>
Field:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another comment.

<button type="button">Generate Report</button>
<hr>
<h1>My Sample Harvest Report</h1>
<p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants