-
Notifications
You must be signed in to change notification settings - Fork 35
Seeding Input: Test Seeding Log Creation #224
base: main
Are you sure you want to change the base?
Seeding Input: Test Seeding Log Creation #224
Conversation
Signed-off-by: won369369 <[email protected]>
This reverts commit fff6611.
…eir existing values in tray seeding and direct seeding
…cypress/fieldkit.tab.spec.js
@won369369 Self-assigning to track this PR easily on the mentioned PR page. |
@@ -0,0 +1,433 @@ | |||
const dayjs = require('dayjs') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a general comment at the top of the file explaining the purpose of this file.
Very nice solution to a challenging test scenario. I think this will be ready to merge once you add a general comment at the top of the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a general comment at the top of the file as suggested. This pull request is ready to be reviewed again @johnmaccormick.
I'm seeing a few failed tests here. The first failure produces the message:
Can you confirm that all tests pass when you run them? (Also check you have all latest changes from upstream main) Thanks! |
All of the tests passed for me. @johnmaccormick have you reviewed this PR again? |
Pull Request Description
Addresses #203
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.