Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Seeding Input: Test Seeding Log Creation #224

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

JinLeeGG
Copy link

Pull Request Description

Addresses #203


Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

won369369 and others added 30 commits April 3, 2023 21:26
Signed-off-by: won369369 <[email protected]>
…eir existing values in tray seeding and direct seeding
@JinLeeGG JinLeeGG marked this pull request as ready for review April 27, 2023 02:28
@won369369
Copy link

won369369 commented Apr 27, 2023

@won369369 Self-assigning to track this PR easily on the mentioned PR page.

@@ -0,0 +1,433 @@
const dayjs = require('dayjs')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a general comment at the top of the file explaining the purpose of this file.

@johnmaccormick
Copy link
Collaborator

Very nice solution to a challenging test scenario. I think this will be ready to merge once you add a general comment at the top of the file.

Copy link

@Shahir-47 Shahir-47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a general comment at the top of the file as suggested. This pull request is ready to be reviewed again @johnmaccormick.

@johnmaccormick
Copy link
Collaborator

I'm seeing a few failed tests here. The first failure produces the message:

1) Tests for SeedingInput log creation
       Checks all of the input elements in the form remain populated with their existing values in direct seeding:
     CypressError: Timed out retrying after 10000ms: `cy.select()` failed because it could not find a single `<option>` with value, index, or text matching: `ARUGULA`

Can you confirm that all tests pass when you run them? (Also check you have all latest changes from upstream main) Thanks!

@braughtg
Copy link
Member

All of the tests passed for me.

image

@johnmaccormick have you reviewed this PR again?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants