Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for commands execution related to hyperloglog (3) #30

Closed
lucifercr07 opened this issue Oct 5, 2024 · 4 comments
Closed
Assignees
Labels

Comments

@lucifercr07
Copy link
Contributor

lucifercr07 commented Oct 5, 2024

This issue involves creating the test cases for playground-mono repo:

Source: internal/tests/integration/commands/

  • pfadd_test.go
  • pfcount_test.go
  • pfmerge_test.go

Steps:

  1. Create the corresponding tests for these commands in internal/tests/integration/commands/
  2. We can use this file from dice repo for reference.
  3. Run the tests and fix issues with command parsing in server.

If you need to do anything custom feel free to comment on this issue for more details.

NOTE: Please consider that for the integration tests we should ideally have a dice server spin up via Docker container in Go and then write integration tests. We can use Go Libraries like testcontainers-go for this.

@tarun-kavipurapu
Copy link
Contributor

tarun-kavipurapu commented Oct 5, 2024

@lucifercr07 can you assign this to me

@lucifercr07
Copy link
Contributor Author

@tarun-kavipurapu assigned, thanks for contributing.

@lucifercr07
Copy link
Contributor Author

@tarun-kavipurapu initial structure for integration tests are in, please let us know if any other details are required.

@lucifercr07
Copy link
Contributor Author

Closing merged as part of #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants