Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"test5" movie metadata mismatches #1135

Open
ptrcnull opened this issue Jun 25, 2024 · 4 comments
Open

"test5" movie metadata mismatches #1135

ptrcnull opened this issue Jun 25, 2024 · 4 comments

Comments

@ptrcnull
Copy link
Collaborator

( not yet sure what causes it, could be bumped dependencies )
in 2.2.0, test_refine_video_metadata started failing on video_codec and release_group:

_________________________________ test_refine_video_metadata __________________________________

    def test_refine_video_metadata(mkv):
        scanned_video = scan_video(mkv['test5'])
        refine(scanned_video, episode_refiners=('metadata',), movie_refiners=('metadata',))
        assert type(scanned_video) is Movie
        assert scanned_video.name == mkv['test5']
        assert scanned_video.source is None
        assert scanned_video.release_group is None
        assert scanned_video.resolution is None
>       assert scanned_video.video_codec == 'H.264'
E       AssertionError: assert None == 'H.264'
E        +  where None = <Movie [test5]>.video_codec

tests/test_core.py:256: AssertionError
_________________________________ test_refine_video_metadata __________________________________

    def test_refine_video_metadata(mkv):
        scanned_video = scan_video(mkv['test5'])
        refine(scanned_video, episode_refiners=('metadata',), movie_refiners=('metadata',))
        assert type(scanned_video) is Movie
        assert scanned_video.name == mkv['test5']
        assert scanned_video.source is None
>       assert scanned_video.release_group is None
E       AssertionError: assert 'subliminal' is None
E        +  where 'subliminal' = <Movie [2]>.release_group

tests/test_core.py:254: AssertionError
@getzze
Copy link
Collaborator

getzze commented Jun 25, 2024

It looks like enzyme was not updated to version 0.5.0. Earlier versions don't work with python 3.12 if you don't have setuptools manually installed. See #1126

@ptrcnull
Copy link
Collaborator Author

ptrcnull commented Jun 25, 2024

i can reproduce the latter with enzyme 0.5.1, and setuptools installed as well

@getzze
Copy link
Collaborator

getzze commented Jun 25, 2024 via email

@getzze
Copy link
Collaborator

getzze commented Jul 22, 2024

So it is a feature of guessit to look for parent folder to guess the name and other stuff. Because the filename test5.mkv is not indicative enough, it looks for the parents. In case of #1157, the subliminal-2.2.1 parent folder was parsed as release_group and name. I will remove this assert in #1154, so it should be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants