Skip to content

Conversation

@tpoliaw
Copy link
Collaborator

@tpoliaw tpoliaw commented Feb 13, 2025

These templates would follow the same templating rules as the scan file template
but allow specific detectors to use different templating if required. The
additional templates would be registered for a specific beamline, and could then
be used in queries when getting scan files/number etc.

A query would then look something like

mutation {
  scan(instrument: "i22", instrumentSession:"cm1234-5", sub: "foo/bar") {
    scanNumber
    oav: template(name: "oav")
    snapshot: template(name: "snap")
  }
}

Which would then return something along the lines of

{
  "data": {
    "scan": {
      "scanNumber": 146,
      "oav": "oav/146",
      "snapshot": "foo/bar/snapshots/snap_146"
    }
  }
}

depending on how the templates are configured.

@tpoliaw
Copy link
Collaborator Author

tpoliaw commented Apr 23, 2025

@noemifrisina

@tpoliaw tpoliaw marked this pull request as ready for review August 27, 2025 12:41
@tpoliaw tpoliaw changed the title Work in progress towards named templates Support named templates per instrument Aug 27, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 14.81481% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.16%. Comparing base (fb53cca) to head (d97b770).

Files with missing lines Patch % Lines
src/db_service.rs 22.72% 51 Missing ⚠️
src/graphql/mod.rs 2.38% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   77.52%   74.16%   -3.36%     
==========================================
  Files          13       13              
  Lines        1909     2017     +108     
==========================================
+ Hits         1480     1496      +16     
- Misses        429      521      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants