Async Queue Refactor

include/nbl/asset/IAssetManager.h

@@ -330,14 +330,12 @@ class NBL_API2 IAssetManager : public core::IReferenceCounted, public core::Quit
                 filePath = _params.workingDirectory/filePath;
                 _override->getLoadFilename(filePath, m_system.get(), ctx, _hierarchyLevel);
             }
-
+            
             system::ISystem::future_t<core::smart_refctd_ptr<system::IFile>> future;
             m_system->createFile(future, filePath, system::IFile::ECF_READ);
-            auto file = future.get();
-            if (!file)
-                return SAssetBundle(0);
-
-            return getAssetInHierarchy_impl<RestoreWholeBundle>(file.get(), filePath.string(), ctx.params, _hierarchyLevel, _override);
+            if (auto file=future.acquire())
+                return getAssetInHierarchy_impl<RestoreWholeBundle>(file->get(), filePath.string(), ctx.params, _hierarchyLevel, _override);
+            return SAssetBundle(0);
         }
 
         //TODO change name
@@ -652,15 +650,10 @@ class NBL_API2 IAssetManager : public core::IReferenceCounted, public core::Quit
                 _override = &defOverride;
 
             system::ISystem::future_t<core::smart_refctd_ptr<system::IFile>> future;
-            m_system->createFile(future, (_params.workingDirectory.generic_string() + _filename).c_str(), system::IFile::ECF_WRITE);
-            auto file = future.get();
-			if (file) // could fail creating file (lack of permissions)
-			{
-				bool res = writeAsset(file.get(), _params, _override);
-				return res;
-			}
-			else
-				return false;
+            m_system->createFile(future, (_params.workingDirectory.generic_string()+_filename).c_str(), system::IFile::ECF_WRITE);
+            if (auto file=future.acquire())
+                return writeAsset(file->get(), _params, _override);
+            return false;
         }
         bool writeAsset(system::IFile* _file, const IAssetWriter::SAssetWriteParams& _params, IAssetWriter::IAssetWriterOverride* _override)
         {

include/nbl/core/StorageTrivializer.h

@@ -0,0 +1,42 @@
+#ifndef __NBL_CORE_STORAGE_TRIVIALIZER_H_INCLUDED__
+#define __NBL_CORE_STORAGE_TRIVIALIZER_H_INCLUDED__
+
+namespace nbl::core
+{
+
+// This construct makes it so that we don't trigger T's constructors and destructors.
+template<typename T>
+struct StorageTrivializer;
+
+template<>
+struct NBL_FORCE_EBO StorageTrivializer<void>
+{
+    void* getStorage() {return nullptr;}
+    const void* getStorage() const {return nullptr;}
+
+    void construct() {}
+    void destruct() {}
+};
+
+template<typename T>
+struct alignas(T) StorageTrivializer
+{
+    T* getStorage() {return reinterpret_cast<T*>(storage); }
+    const T* getStorage() const {return reinterpret_cast<const T*>(storage);}
+
+    template<typename... Args>
+    void construct(Args&&... args)
+    {
+        new (getStorage()) T(std::forward<Args>(args)...);
+    }
+    void destruct()
+    {
+        getStorage()->~T();
+    }
+
+    uint8_t* storage[sizeof(T)];
+};
+
+}
+
+#endif

include/nbl/core/declarations.h

@@ -66,6 +66,7 @@
 #include "nbl/core/EventDeferredHandler.h"
 #include "nbl/core/IBuffer.h"
 #include "nbl/core/IReferenceCounted.h"
+#include "nbl/core/StorageTrivializer.h"
 #include "nbl/core/SRAIIBasedExiter.h"
 #include "nbl/core/SRange.h"
 #include "nbl/core/Byteswap.h"

include/nbl/system/CFileLogger.h

@@ -21,9 +21,9 @@ class CFileLogger : public IThreadsafeLogger
 		virtual void threadsafeLog_impl(const std::string_view& fmt, E_LOG_LEVEL logLevel, va_list args) override
 		{
 			const auto str = constructLogString(fmt, logLevel, args);
-			ISystem::future_t<size_t> future;
-			m_file->write(future,str.data(),m_pos,str.length());
-			m_pos += future.get(); // need to use the future to make sure op is actually executed :(
+			IFile::success_t succ;
+			m_file->write(succ,str.data(),m_pos,str.length());
+			m_pos += succ.getBytesProcessed();
 		}
 
 		core::smart_refctd_ptr<IFile> m_file;