Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to use IronRDP with Tokio #188

Closed
wants to merge 1 commit into from
Closed

Make it easier to use IronRDP with Tokio #188

wants to merge 1 commit into from

Conversation

probakowski
Copy link
Collaborator

Various types used in connection sequence were not picked up as Send or Sync which made it impossible to use inside tokio::spawn blocks

@CBenoit CBenoit self-assigned this Aug 30, 2023
@CBenoit
Copy link
Member

CBenoit commented Aug 31, 2023

Build is failing for ironrdp-futures. Also, I think this approach will be a problem for ironrdp-web because WebSocket is !Send, we probably need another approach.

@CBenoit CBenoit added the A-extra Area: Extra tier label Aug 31, 2023
@CBenoit
Copy link
Member

CBenoit commented Sep 1, 2023 •
edited
Loading

I found an alternative approach using GATs: #189

@CBenoit CBenoit mentioned this pull request Sep 1, 2023
Merged
@probakowski
Copy link
Collaborator Author

Closing in favor of #189

@probakowski probakowski closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CBenoit CBenoit

Labels
A-extra Area: Extra tier
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@probakowski @CBenoit