Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App fully stopped working #281

Closed
notNSANE opened this issue Aug 21, 2023 · 22 comments · Fixed by #282
Closed

App fully stopped working #281

notNSANE opened this issue Aug 21, 2023 · 22 comments · Fixed by #282

Comments

@notNSANE
Copy link

notNSANE commented Aug 21, 2023

App stopped working some minutes ago, now only gives this error everytime.

18:23:14: Fatal error encountered:
18:23:14:
18:23:14: Traceback (most recent call last):
18:23:14: File "main.py", line 175, in main
18:23:14: File "twitch.py", line 765, in run
18:23:14: File "twitch.py", line 906, in _run
18:23:14: File "channel.py", line 269, in update_stream
18:23:14: File "channel.py", line 258, in get_stream
18:23:14: File "channel.py", line 47, in from_get_stream
18:23:14: File "channel.py", line 39, in init
18:23:14: TypeError: 'NoneType' object is not iterable
18:23:14:
18:23:14: Exiting...
18:23:14:
18:23:14: Application Terminated.
18:23:14: Close the window to exit the application.

@notNSANE notNSANE changed the title App stopped working App fully stopped working Aug 21, 2023
@gmorks
Copy link

gmorks commented Aug 21, 2023

getting the same error, built it from dev

@Js41637
Copy link

Js41637 commented Aug 21, 2023

The app is crashing because its trying to see if a channel has the drops enabled tag however the GQL API Operation that the app uses (GetStreamInfo) no longer returns the tags and they're now null (or None)

Not sure if there's another Operation that returns all the info in a single request. You'll probably need to make a seperate request to the RealtimeStreamTagList or StreamTagsTrackingChannel operation which both return tags for a channel and its current stream.

@Qiaofanxing
Copy link

Yeah, I had the same problem.

@ProCasual
Copy link

Yep, seems twitch changed something and it's busted again... dev is amazing at fixing this app every time that happens. Really appreciate their work. Would be so great if we could auto-update the app too as sometimes I don't notice it's not working. That feature would get a donation from me.

@2eyan9
Copy link

2eyan9 commented Aug 22, 2023

I had the same problem.
36f7bb54a62f896e2af613fb0daae84

@stijndp
Copy link

stijndp commented Aug 22, 2023

#264 (comment)
Not 2 weeks ago...

Maybe as a temporary solution the channel with the most viewers could be chosen? Without knowing, that will have the highest chance of having drops.
And after x time it can be checked if indeed progress is made.

@i20i
Copy link

i20i commented Aug 22, 2023

I had the same problem too.

15:16:35: Fatal error encountered:
15:16:35:
15:16:35: Traceback (most recent call last):
15:16:35: File "main.py", line 175, in main
15:16:35: File "twitch.py", line 765, in run
15:16:35: File "twitch.py", line 906, in _run
15:16:35: File "channel.py", line 269, in update_stream
15:16:35: File "channel.py", line 258, in get_stream
15:16:35: File "channel.py", line 47, in from_get_stream
15:16:35: File "channel.py", line 39, in init
15:16:35: TypeError: 'NoneType' object is not iterable

@knuthen
Copy link

knuthen commented Aug 22, 2023

After not working yesterday, the miner resumed to work again as of now. Running d5410b2 with the @guihkx fix

@gmorks
Copy link

gmorks commented Aug 22, 2023

After not working yesterday, the miner resumed to work again as of now. Running d5410b2 with the @guihkx fix

I build it today, and those errors are from today

@pw1602
Copy link

pw1602 commented Aug 22, 2023

diff --git a/channel.py b/channel.py
index 313708d..581d219 100644
--- a/channel.py
+++ b/channel.py
@@ -50,7 +50,7 @@ class Stream:
             game=settings["game"],
             viewers=stream["viewersCount"],
             title=settings["title"],
-            tags=stream["tags"],
+            tags=stream["tags"] or [],
         )

I've made changes like above and it's working. Drops are progressing without problems and claimed without problems too. Tested on TES Online drop.

@knuthen
Copy link

knuthen commented Aug 22, 2023

I checked in with a friend who is running the same build as I and for him it seems to works as well.
I also tested the latest two commits both running both build and unbuild. Everything is working on my end.

@gmorks
Copy link

gmorks commented Aug 22, 2023

maybe something changed over twitch, just launch it not changing anything and it's working... weird

@2eyan9
Copy link

2eyan9 commented Aug 22, 2023

I had the same problem. 36f7bb54a62f896e2af613fb0daae84

A few hours later, I reopened the .exe file and found that the issue had disappeared.During that time, I built the latest version and was prompted to use the newest cookies.

@Danzo51196
Copy link

A few hours later, I reopened the .exe file and found that the issue had disappeared.During that time, I built the latest version and was prompted to use the newest cookies.

Can confirm this.

@pw1602
Copy link

pw1602 commented Aug 22, 2023

Did someone receive a Trojan:Win32/Bearfoos.A!ml alert after compile .exe?
I've made this changes but don't work for me.

No alert at all. I've checked again and without those changes it's still not working for me, but with changes it works. I am up to date with master branch.

@OffensiveExile
Copy link

Did someone receive a Trojan:Win32/Bearfoos.A!ml alert after compile .exe?

I've made this changes but don't work for me.

> -            tags=stream["tags"],
> +            tags=stream["tags"] or [],

Screenshot_4 Screenshot_5

The beauty about open source projects is that you can always check the code whenever you want and even recent commits: https://github.com/DevilXD/TwitchDropsMiner/commits/master

It's most likely a false positive due to how Python compiles the scripts.

@SufferMeNow
Copy link

diff --git a/channel.py b/channel.py
index 313708d..581d219 100644
--- a/channel.py
+++ b/channel.py
@@ -50,7 +50,7 @@ class Stream:
             game=settings["game"],
             viewers=stream["viewersCount"],
             title=settings["title"],
-            tags=stream["tags"],
+            tags=stream["tags"] or [],
         )

I've made changes like above and it's working. Drops are progressing without problems and claimed without problems too. Tested on TES Online drop.

It works for me too. Thanks.

@Diseraph
Copy link

I'm very new to how open source stuff works. How do I take advantage of teh smart cookies in here who are affecting the source code?

@stijndp
Copy link

stijndp commented Aug 22, 2023

I'm very new to how open source stuff works. How do I take advantage of teh smart cookies in here who are affecting the source code?

You can use the following guide describing the process.

Preferably DevilXD tests the change, checks it in and kicks off a build. Or gives checkin permissions to someone trusty to follow his goals, spirit and quality of the project while his time is being stolen by the pesky fact of life called a job.

@notNSANE
Copy link
Author

notNSANE commented Aug 22, 2023

I'll rettest with new cookies. Perhaps it might be a regional issue? Worth checking.

edit: didn't work.

@DevilXD DevilXD linked a pull request Aug 22, 2023 that will close this issue
@notNSANE
Copy link
Author

@DevilXD I was thinking... this issue in my case, got automatically fixed when the new game, Marvel Snap, could be farmed.

Something weird happened, since the Miner could see the Marvel Snap category before it was even launched on the Twitch website, as in, I couldn't see Marvel Snap as a category before in Twitch's own Open Campaigns site. And that's the timeframe where this app crashed.

Once the Twitch's Special Event launched (Gamescom), the new category appeared (Marvel Snap) and the issue was magically solved. Perhaps this was the issue?

@DevilXD
Copy link
Owner

DevilXD commented Aug 23, 2023

It's too late to debug this issue like that, I'd think. The tags array was a remainder from the times where Twitch could provide the "Drops Enabled" tag via that array, but since that's no longer the case, and no other tags were being checked, it's currently a useless piece of code that only slows down the program. One more thing to take care of during #220, and that's it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

16 participants