-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App fully stopped working #281
Comments
getting the same error, built it from dev |
The app is crashing because its trying to see if a channel has the drops enabled tag however the GQL API Operation that the app uses (GetStreamInfo) no longer returns the tags and they're now null (or None) Not sure if there's another Operation that returns all the info in a single request. You'll probably need to make a seperate request to the |
Yeah, I had the same problem. |
Yep, seems twitch changed something and it's busted again... dev is amazing at fixing this app every time that happens. Really appreciate their work. Would be so great if we could auto-update the app too as sometimes I don't notice it's not working. That feature would get a donation from me. |
#264 (comment) Maybe as a temporary solution the channel with the most viewers could be chosen? Without knowing, that will have the highest chance of having drops. |
I had the same problem too. 15:16:35: Fatal error encountered: |
diff --git a/channel.py b/channel.py
index 313708d..581d219 100644
--- a/channel.py
+++ b/channel.py
@@ -50,7 +50,7 @@ class Stream:
game=settings["game"],
viewers=stream["viewersCount"],
title=settings["title"],
- tags=stream["tags"],
+ tags=stream["tags"] or [],
) I've made changes like above and it's working. Drops are progressing without problems and claimed without problems too. Tested on TES Online drop. |
I checked in with a friend who is running the same build as I and for him it seems to works as well. |
maybe something changed over twitch, just launch it not changing anything and it's working... weird |
Can confirm this. |
No alert at all. I've checked again and without those changes it's still not working for me, but with changes it works. I am up to date with master branch. |
The beauty about open source projects is that you can always check the code whenever you want and even recent commits: https://github.com/DevilXD/TwitchDropsMiner/commits/master It's most likely a false positive due to how Python compiles the scripts. |
It works for me too. Thanks. |
I'm very new to how open source stuff works. How do I take advantage of teh smart cookies in here who are affecting the source code? |
You can use the following guide describing the process. Preferably DevilXD tests the change, checks it in and kicks off a build. Or gives checkin permissions to someone trusty to follow his goals, spirit and quality of the project while his time is being stolen by the pesky fact of life called a job. |
I'll rettest with new cookies. Perhaps it might be a regional issue? Worth checking. edit: didn't work. |
@DevilXD I was thinking... this issue in my case, got automatically fixed when the new game, Marvel Snap, could be farmed. Something weird happened, since the Miner could see the Marvel Snap category before it was even launched on the Twitch website, as in, I couldn't see Marvel Snap as a category before in Twitch's own Open Campaigns site. And that's the timeframe where this app crashed. Once the Twitch's Special Event launched (Gamescom), the new category appeared (Marvel Snap) and the issue was magically solved. Perhaps this was the issue? |
It's too late to debug this issue like that, I'd think. The tags array was a remainder from the times where Twitch could provide the "Drops Enabled" tag via that array, but since that's no longer the case, and no other tags were being checked, it's currently a useless piece of code that only slows down the program. One more thing to take care of during #220, and that's it. |
App stopped working some minutes ago, now only gives this error everytime.
18:23:14: Fatal error encountered:
18:23:14:
18:23:14: Traceback (most recent call last):
18:23:14: File "main.py", line 175, in main
18:23:14: File "twitch.py", line 765, in run
18:23:14: File "twitch.py", line 906, in _run
18:23:14: File "channel.py", line 269, in update_stream
18:23:14: File "channel.py", line 258, in get_stream
18:23:14: File "channel.py", line 47, in from_get_stream
18:23:14: File "channel.py", line 39, in init
18:23:14: TypeError: 'NoneType' object is not iterable
18:23:14:
18:23:14: Exiting...
18:23:14:
18:23:14: Application Terminated.
18:23:14: Close the window to exit the application.
The text was updated successfully, but these errors were encountered: