Pulsing Syntax Improvement #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sheduling a removal of the class just before the pulse, you can simply write those two functions one after another. The addClass function will only be called after the removeClass function. I haven't tested it, so I might be wrong, but I think the time it takes for the removeClass function to remove the class is so tiny that you won't see any delays in the scaling of the player. Great video by the way, keep on hacking!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sheduling a removal of the class just before the pulse, you can simply write those two functions one after another. The addClass function will only be called after the removeClass function.
I haven't tested it, so I might be wrong, but I think the time it takes for the removeClass function to remove the class is so tiny that you won't see any delays in the scaling of the player.
Great video by the way, keep on hacking!