Skip to content

Conversation

DevTKSS
Copy link
Owner

@DevTKSS DevTKSS commented Sep 3, 2025

  • Add a seperate project showcasing how to add and update Items in a Mvux bound ListState Source in the Model
  • Postproduce and upload the recorded Video
  • Link Video to the Readme

@Copilot Copilot AI review requested due to automatic review settings September 3, 2025 21:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new sample application "MvuxListApp" that demonstrates how to implement list selection and item modification using Uno Platform's MVUX framework. The app showcases binding to a ListState source and performing operations like renaming selected items.

Key changes:

  • Created a complete MVUX sample application with list management functionality
  • Added project configuration files and build settings for the new app
  • Integrated the new project into the solution and workspace configuration

Reviewed Changes

Copilot reviewed 32 out of 35 changed files in this pull request and generated 7 comments.

File Description
src/MvuxListApp/ Complete new sample application showcasing MVUX ListState operations
src/DevTKSS.Uno.Samples.sln Added MvuxListApp project to solution
src/DevTKSS.Uno.SampleApps-Tutorials.slnf Added MvuxListApp to solution filter
src/.vscode/ Updated VS Code configuration for debugging and building the new app

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 46 to 61
public IState<string> ModifyedMemberName => State<string>.Empty(this)
.ForEach(RenameMemberAsync);

public async ValueTask RenameMemberAsync([FeedParameter(nameof(ModifyedMemberName))]string? modifyedName, CancellationToken ct)
{

string replaceMeItem = await SelectedMember ?? string.Empty;
string modifyedItem = await ModifyedMemberName ?? string.Empty;
_logger.LogInformation("Modifyed MemberName ist: {modifyedItem}", modifyedItem);
_logger.LogInformation("SelectedMemeber ist: {selectedMember}", replaceMeItem);

await DashboardList.RemoveAllAsync(item => item == replaceMeItem);

await DashboardList.AddAsync(modifyedItem,ct);

await DashboardList.TrySelectAsync(modifyedItem,ct);
Copy link
Preview

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple spelling errors: 'modifyedName' should be 'modifiedName', 'modifyedItem' should be 'modifiedItem', and 'Modifyed' should be 'Modified' in the log message.

Suggested change
public IState<string> ModifyedMemberName => State<string>.Empty(this)
.ForEach(RenameMemberAsync);
public async ValueTask RenameMemberAsync([FeedParameter(nameof(ModifyedMemberName))]string? modifyedName, CancellationToken ct)
{
string replaceMeItem = await SelectedMember ?? string.Empty;
string modifyedItem = await ModifyedMemberName ?? string.Empty;
_logger.LogInformation("Modifyed MemberName ist: {modifyedItem}", modifyedItem);
_logger.LogInformation("SelectedMemeber ist: {selectedMember}", replaceMeItem);
await DashboardList.RemoveAllAsync(item => item == replaceMeItem);
await DashboardList.AddAsync(modifyedItem,ct);
await DashboardList.TrySelectAsync(modifyedItem,ct);
public IState<string> ModifiedMemberName => State<string>.Empty(this)
.ForEach(RenameMemberAsync);
public async ValueTask RenameMemberAsync([FeedParameter(nameof(ModifiedMemberName))]string? modifiedName, CancellationToken ct)
{
string replaceMeItem = await SelectedMember ?? string.Empty;
string modifiedItem = await ModifiedMemberName ?? string.Empty;
_logger.LogInformation("Modified MemberName ist: {modifiedItem}", modifiedItem);
_logger.LogInformation("SelectedMemeber ist: {selectedMember}", replaceMeItem);
await DashboardList.RemoveAllAsync(item => item == replaceMeItem);
await DashboardList.AddAsync(modifiedItem,ct);
await DashboardList.TrySelectAsync(modifiedItem,ct);

Copilot uses AI. Check for mistakes.

"type": "process",
"args": [
"build",
"${workspaceFolder}/MvuxListApp/MvuxListApp.csproj",
Copy link
Preview

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project path references 'MvuxListApp.csproj' but the actual project file is 'DevTKSS.Uno.MvuxListApp.csproj'. This will cause the build task to fail.

Copilot uses AI. Check for mistakes.

"type": "process",
"args": [
"publish",
"${workspaceFolder}/MvuxListApp/MvuxListApp.csproj",
Copy link
Preview

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project path references 'MvuxListApp.csproj' but the actual project file is 'DevTKSS.Uno.MvuxListApp.csproj'. This will cause the publish task to fail.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant