Skip to content

Conversation

@PavelMor25
Copy link
Contributor

@PavelMor25 PavelMor25 commented Mar 19, 2024

Purpose

closes Devexpress/testcafe-private/issues/479

Approach

Describe how your changes address the issue or implement the desired functionality in as much detail as possible.

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 19, 2024
@PavelMor25 PavelMor25 removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 19, 2024
@PavelMor25 PavelMor25 requested a review from Aleksey28 March 20, 2024 04:42
Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, look at my comments. After that update type definitions here https://github.com/DevExpress/testcafe/tree/master/ts-defs-src

Copy link
Collaborator

@Aleksey28 Aleksey28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, look at my comments, and also add definition tests to this directory: https://github.com/DevExpress/testcafe/blob/master/test/server/compiler-test.js
As example, you can explore how it was made for getCurrentWindow.

@Aleksey28 Aleksey28 requested review from Bayheck and titerman March 28, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants