Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Starting from Node version 20 Hooks like
loadrun in a separate thread, isolated from the main thread.https://nodejs.org/docs/latest-v20.x/api/module.html#hooks.
Our current implementation relies on main thread in
getTestFileCompilers.Because the
loadhook is now running in a separate thread thetestFileCompilerswas never initialized before, andgetTestFileCompilerscallsinitTestFileCompilerswith no parameters. That is why theesmflag is lost in Node version 20 and above.Approach
Pass the
esmflag fromloadhook to getTestFileCompilers` in order to initialize the correct compilers.The test 'Should import ESM without errors in ESM mode' also works for this fix in node 20 and above.
References
closes #8132
Pre-Merge TODO