fix: In concurrent test run fixed awaiting of fixture before hook #8097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
AlexKamaev
requested changes
Dec 1, 2023
test/functional/fixtures/concurrency/testcafe-fixtures/concurrent-fixture-before-test.js
Outdated
Show resolved
Hide resolved
test/functional/fixtures/concurrency/testcafe-fixtures/concurrent-fixture-before-test.js
Outdated
Show resolved
Hide resolved
PavelMor25
removed
the
STATE: Need response
AlexKamaev
requested changes
Dec 4, 2023
test/functional/fixtures/concurrency/testcafe-fixtures/concurrent-fixture-before-test.js
Show resolved
Hide resolved
AlexKamaev
requested changes
Dec 7, 2023
AlexKamaev
approved these changes
Dec 7, 2023
Contributor
|
@Aleksey28 please review |
Aleksey28
requested changes
Dec 7, 2023
Collaborator
Aleksey28
left a comment
Aleksey28
left a comment
There was a problem hiding this comment.
Your style is getting better, but there are a few moments with naming.
Aleksey28
approved these changes
Dec 7, 2023
|
Release v3.5.0-rc.1 addresses this. |
1 similar comment
|
Release v3.5.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixed the bug when the concurrent tests did not wait until the finish of the fixture and global before hook.
Approach
Updated the method runFixtureBeforeHookIfNecessary in src/runner/fixture-hook-controller.ts. Now we store the promises of hooks in item from _getFixtureMapItem and await them in concurrent tests.
References
closes #6999
Pre-Merge TODO