wait for Temp directory is initialized for video recording (closes #3508) #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit a9190df have failed. See details: |
|
❌ Tests for the commit a9190df have failed. See details: |
AndreyBelym
suggested changes
Mar 19, 2019
| @@ -58,7 +58,10 @@ export default class VideoRecorder { | |||
| } | |||
|
|
|||
| _assignEventHandlers (browserJob) { | |||
| browserJob.once('start', this._createSafeListener(this._onBrowserJobStart)); | |||
| browserJob.once('start', this._createSafeListener(() => { | |||
There was a problem hiding this comment.
Please add the async modifier and add await this.tempDirectoryInitializedPromise OR return this.tempDirectoryInitializedPromise from the handler.
|
❌ Tests for the commit a9190df have failed. See details: |
AndreyBelym
approved these changes
Mar 19, 2019
|
❌ Tests for the commit 1d27ef8 have failed. See details: |
|
❌ Tests for the commit 1d27ef8 have failed. See details: |
|
❌ Tests for the commit 1d27ef8 have failed. See details: |
|
❌ Tests for the commit 1d27ef8 have failed. See details: |
|
✅ Tests for the commit 1d27ef8 have passed. See details: |
|
ping @LavrovArtem |
LavrovArtem
approved these changes
Mar 20, 2019
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…vExpress#3508) (DevExpress#3577) * wait for Temp directory is initialized for video recording (closes DevExpress#3508) * return promise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.