New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement video recording #3257

Merged

AndreyBelym merged 3 commits into DevExpress:master from AndreyBelym:video-recording

Jan 25, 2019

Contributor

AndreyBelym commented Dec 26, 2018

No description provided.

shyedhu commented Dec 26, 2018

I would like to try video recording feature with testcafe in my project .. Can you please let me know when you have a plan to release the video recording feature?

Contributor Author

AndreyBelym commented Dec 27, 2018

Hi @shyedhu, we're going to release it in [email protected] in January 2019.

AndreyBelym force-pushed the video-recording branch from ab5ae58 to a843fa5 Compare

December 27, 2018 07:44

shyedhu commented Dec 27, 2018

Hi @shyedhu, we're going to release it in [email protected] in January 2019.

Thanks for your quick response

AndreyBelym force-pushed the video-recording branch 4 times, most recently from b328fb9 to 9dc1600 Compare

January 16, 2019 11:04

kirovboris requested changes

View reviewed changes

Collaborator

kirovboris left a comment

/r-

src/browser/provider/built-in/firefox/marionette-client/index.js Outdated Show resolved Hide resolved

src/utils/detect-ffmpeg.js Outdated Show resolved Hide resolved

src/utils/get-options/base.js Show resolved Hide resolved

src/utils/get-options/ssl.js Outdated Show resolved Hide resolved

src/video-recorder/index.js Outdated Show resolved Hide resolved

src/video-recorder/process.js Show resolved Hide resolved

AndreyBelym force-pushed the video-recording branch 2 times, most recently from 6cf8100 to ca29777 Compare

January 18, 2019 03:58

Collaborator

testcafe-build-bot commented Jan 18, 2019

❌ Tests for the commit ca29777 have failed. See details:

Collaborator

testcafe-build-bot commented Jan 18, 2019

❌ Tests for the commit cf9b546 have failed. See details:

AndreyBelym changed the title ~~[WIP] Implement video recording~~ Implement video recording

Collaborator

testcafe-build-bot commented Jan 18, 2019

❌ Tests for the commit cf9b546 have failed. See details:

AndreyBelym requested review from helen-dikareva and AlexKamaev

January 18, 2019 13:36

Collaborator

testcafe-build-bot commented Jan 21, 2019

✅ Tests for the commit cf9b546 have passed. See details:

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

DevExpress deleted a comment from testcafe-build-bot

Collaborator

testcafe-build-bot commented Jan 21, 2019

❌ Tests for the commit 37b9c2a have failed. See details:

Collaborator

testcafe-build-bot commented Jan 21, 2019

❌ Tests for the commit 68be7a0 have failed. See details:

Collaborator

testcafe-build-bot commented Jan 22, 2019

❌ Tests for the commit ea0f517 have failed. See details:

AndreyBelym force-pushed the video-recording branch from ea0f517 to 3953af3 Compare

January 22, 2019 14:07

Collaborator

testcafe-build-bot commented Jan 22, 2019

❌ Tests for the commit 3953af3 have failed. See details:

Collaborator

testcafe-build-bot commented Jan 23, 2019

✅ Tests for the commit 3953af3 have passed. See details:


          Implement video recording

fd1fd5a

AndreyBelym force-pushed the video-recording branch from 3953af3 to fd1fd5a Compare

January 23, 2019 12:11

Collaborator

testcafe-build-bot commented Jan 23, 2019

❌ Tests for the commit fd1fd5a have failed. See details:

Collaborator

testcafe-build-bot commented Jan 23, 2019

❌ Tests for the commit fd1fd5a have failed. See details:

Collaborator

testcafe-build-bot commented Jan 23, 2019

❌ Tests for the commit fd1fd5a have failed. See details:

Collaborator

testcafe-build-bot commented Jan 23, 2019

❌ Tests for the commit fd1fd5a have failed. See details:

Collaborator

testcafe-build-bot commented Jan 23, 2019

❌ Tests for the commit fd1fd5a have failed. See details:

peteygao commented Jan 23, 2019

Hi @shyedhu, we're going to release it in [email protected] in January 2019.

Hey @AndreyBelym, is this feature still slated for a January 2019 release? Or has [email protected] been pushed back?

helen-dikareva reviewed

View reviewed changes

src/errors/runtime/message.js Outdated

-                  invalidReporterOutput:                                          "Specify a file name or a writable stream as the reporter's output target."
+                  invalidReporterOutput:                                          "Specify a file name or a writable stream as the reporter's output target.",
+                  cantReadSSLCertFile: 'Unable to read the "{path}" file, specified by the "{option}" ssl option. Error details:\n' +

Collaborator

helen-dikareva Jan 24, 2019

somewhere we have cant and somewhere cannot, let's choose one form

Collaborator

VasilyStrelyaev Jan 24, 2019

let it be cannot

helen-dikareva reviewed

View reviewed changes

src/utils/get-options/index.js Show resolved Hide resolved

...onal/fixtures/api/es-next/native-dialogs-handling/iframe/testcafe-fixtures/page-load-test.js Show resolved Hide resolved

test/functional/fixtures/video-recording/test.js Outdated Show resolved Hide resolved

helen-dikareva reviewed

View reviewed changes

src/notifications/warning-message.js Outdated Show resolved Hide resolved

Contributor Author

AndreyBelym commented Jan 24, 2019

@peteygao, we still expect to release video recording and [email protected] in January. If we face something unexpected, we want to release it in the first weeks of February in the worst case.

AndreyBelym added 2 commits

January 24, 2019 17:23


          Change 'cant' to cannot

57bd122


          Fix remaining remarks

Collaborator

testcafe-build-bot commented Jan 24, 2019

❌ Tests for the commit 7866642 have failed. See details:

Collaborator

testcafe-build-bot commented Jan 25, 2019

✅ Tests for the commit 7866642 have passed. See details:

kirovboris approved these changes

View reviewed changes

AlexKamaev approved these changes

View reviewed changes

helen-dikareva approved these changes

View reviewed changes

AndreyBelym merged commit daa552b into DevExpress:master

kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this pull request


          Implement video recording (DevExpress#3257)

d1a1856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet