fix 'incorrect screenshot path in report output ' (close #2726) #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit bd3ba00 have failed. See details: |
|
❌ Tests for the commit 7e3f14c have failed. See details: |
miherlosev
changed the title
|
✅ Tests for the commit f42ae04 have passed. See details: |
|
@AndreyBelym FPR |
AndreyBelym
suggested changes
Sep 14, 2018
| var config = require('../../../../config'); | ||
| var assertionHelper = require('../../../../assertion-helper'); | ||
| const { expect } = require('chai'); | ||
| const { sync: globby } = require('globby'); |
There was a problem hiding this comment.
I think we don't need globby anymore, because we can just use globs in runner.src.
|
✅ Tests for the commit 692ceff have passed. See details: |
AndreyBelym
approved these changes
Sep 14, 2018
AndreyBelym
requested review from
AlexKamaev
and removed request for
AlexKamaev
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
) (DevExpress#2853) * fix 'incorrect screenshot path in report output ' (close DevExpress#2726) * fix tests - 1 * fix test * fix tests 3 * remove globby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreyBelym