Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart browser if it became unresponsive (closes #1815) #2800

Merged
merged 14 commits into from
Sep 11, 2018

Conversation

AlexKamaev
Copy link
Contributor

@AlexKamaev AlexKamaev commented Sep 3, 2018

I've accidentally closed previous pull request #2746

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 63029a7 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 6807a35 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4560f7e have failed. See details:

@AlexKamaev AlexKamaev closed this Sep 3, 2018
@AlexKamaev AlexKamaev reopened this Sep 3, 2018
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4560f7e have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 01f64b8 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ef811e4 have failed. See details:

4 similar comments
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ef811e4 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ef811e4 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ef811e4 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit ef811e4 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 93b48a3 have failed. See details:

@AlexKamaev AlexKamaev closed this Sep 6, 2018
@AlexKamaev AlexKamaev reopened this Sep 6, 2018
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 1cb58e2 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 400864b have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 400864b have passed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 400864b have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 076e35b have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit d3a12dc have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit a7a45c9 have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit a7a45c9 have passed. See details:

Copy link
Collaborator

@helen-dikareva helen-dikareva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor remarks


this.id = BrowserConnection._generateId();
this.jobQueue = [];
this.initScriptsQueue = [];
this.browserConnectionGateway = gateway;
this.errorSupressed = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo errorSupressed->errorSuppressed
Here and below

this._forceIdle();

let resolveTimeout = null;
let onTimeout = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe isTimeoutExpired

Copy link
Collaborator

@helen-dikareva helen-dikareva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 2612bdd have failed. See details:

1 similar comment
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 2612bdd have failed. See details:

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 2612bdd have passed. See details:

@AlexKamaev AlexKamaev merged commit 462606c into DevExpress:master Sep 11, 2018
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this pull request Dec 18, 2019
…evExpress#2800)

* [WIP]Restart browser if it became unresponsive (closes DevExpress#1815)

* tests

* change approach

* fix server tests

* fix for headless browsers

* fix functional test

* refactor and fix tests

* refactoring and tests

* refactoring

* refactor

* refactoring

* fix and refactoring

* add listenered to connection only when testRun is started

* rename and fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants