-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart browser if it became unresponsive (closes #1815) #2800
Conversation
❌ Tests for the commit 63029a7 have failed. See details: |
63029a7
to
6807a35
Compare
❌ Tests for the commit 6807a35 have failed. See details: |
6807a35
to
4560f7e
Compare
❌ Tests for the commit 4560f7e have failed. See details: |
❌ Tests for the commit 4560f7e have failed. See details: |
4560f7e
to
01f64b8
Compare
❌ Tests for the commit 01f64b8 have failed. See details: |
01f64b8
to
6014daf
Compare
❌ Tests for the commit ef811e4 have failed. See details: |
4 similar comments
❌ Tests for the commit ef811e4 have failed. See details: |
❌ Tests for the commit ef811e4 have failed. See details: |
❌ Tests for the commit ef811e4 have failed. See details: |
❌ Tests for the commit ef811e4 have failed. See details: |
ef811e4
to
93b48a3
Compare
❌ Tests for the commit 93b48a3 have failed. See details: |
❌ Tests for the commit 1cb58e2 have failed. See details: |
❌ Tests for the commit 400864b have failed. See details: |
✅ Tests for the commit 400864b have passed. See details: |
❌ Tests for the commit 400864b have failed. See details: |
❌ Tests for the commit 076e35b have failed. See details: |
❌ Tests for the commit d3a12dc have failed. See details: |
d3a12dc
to
a7a45c9
Compare
❌ Tests for the commit a7a45c9 have failed. See details: |
✅ Tests for the commit a7a45c9 have passed. See details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor remarks
src/browser/connection/index.js
Outdated
|
||
this.id = BrowserConnection._generateId(); | ||
this.jobQueue = []; | ||
this.initScriptsQueue = []; | ||
this.browserConnectionGateway = gateway; | ||
this.errorSupressed = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo errorSupressed->errorSuppressed
Here and below
src/browser/connection/index.js
Outdated
this._forceIdle(); | ||
|
||
let resolveTimeout = null; | ||
let onTimeout = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe isTimeoutExpired
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
❌ Tests for the commit 2612bdd have failed. See details: |
1 similar comment
❌ Tests for the commit 2612bdd have failed. See details: |
✅ Tests for the commit 2612bdd have passed. See details: |
…evExpress#2800) * [WIP]Restart browser if it became unresponsive (closes DevExpress#1815) * tests * change approach * fix server tests * fix for headless browsers * fix functional test * refactor and fix tests * refactoring and tests * refactoring * refactor * refactoring * fix and refactoring * add listenered to connection only when testRun is started * rename and fix typos
I've accidentally closed previous pull request #2746