Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel: use for...of transform for client scripts #2783

Merged
merged 2 commits into from
Aug 31, 2018
Merged

Babel: use for...of transform for client scripts #2783

merged 2 commits into from
Aug 31, 2018

Conversation

Farfurix
Copy link
Contributor

@Farfurix Farfurix commented Aug 29, 2018

DevExpress/testcafe-hammerhead#1651

Changes

  1. Update src/client/.babelrc.
  2. Update Babel options for client function transform. Remove unnecessary typeof modification (addBabelArtifactsPolyfills)

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4a252b9 have failed. See details:

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4a252b9 have failed. See details:

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@Farfurix Farfurix changed the title [WIP] Babel: use for...of transform for client scripts Babel: use for...of transform for client scripts Aug 29, 2018
@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4a252b9 have failed. See details:

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

❌ Tests for the commit 4a252b9 have failed. See details:

@Farfurix
Copy link
Contributor Author

@testcafe-build-bot retest

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit 4a252b9 have passed. See details:

Copy link
Collaborator

@miherlosev miherlosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test that covers the fixed behavior. The test should call directly or indirectly call the BrowserConsoleMessages.getCopy method

@testcafe-build-bot
Copy link
Collaborator

✅ Tests for the commit d46be2f have passed. See details:

@AndreyBelym AndreyBelym merged commit cf5780b into DevExpress:master Aug 31, 2018
@Farfurix Farfurix deleted the update-babelrc branch August 31, 2018 11:35
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants