Added a clear message about failed CORS validation requests (close #2482) #2613
Conversation
miherlosev
changed the title
|
❌ Tests for the commit b9b545d have failed. See details: |
|
❌ Tests for the commit d7760fa have failed. See details: |
| return runTests('./testcafe-fixtures/request-mock/failed-cors-validation.js', 'Failed CORS validation', { only: 'chrome' }) | ||
| .then(() => { | ||
| expect(testReport.warnings).eql([ | ||
| 'RequestMock: CORS validation failed for a request specified as { url: "http://dummy-url.com/get" }' |
There was a problem hiding this comment.
Can we report the fixture name and the test name where the warning emitted?
There was a problem hiding this comment.
For all warning messages we don't report fixture and test name where the warning was emitted.
We can plan this as an enhancement.
Also the warning message contains stringified request filter rule that cause the warning.
|
Could you please explain why have you decided to not throw an error and emit a warning instead? |
This case should not stop a test execution. So, it is not an error. |
|
@testcafe-build-bot retest |
|
✅ Tests for the commit d7760fa have passed. See details: |
|
FPR |
…vExpress#2482) (DevExpress#2613) * add clear message about failed CORS validation requests (close DevExpress#2482) * tmp * formatting * rename * add condition * fix lint
@AndreyBelym
The text of the warning was checked by technical writers.