Implement a possibility to run TestCafe over https (close #1985) #2540
Conversation
|
❌ Tests for the commit 3032990 have failed. See details: |
src/cli/argument-parser.js
Outdated
| @@ -107,6 +107,7 @@ export default class CLIArgumentParser { | |||
| .option('--ports <port1,port2>', 'specify custom port numbers') | |||
| .option('--hostname <name>', 'specify the hostname') | |||
| .option('--proxy <host>', 'specify the host of the proxy server') | |||
| .option('--ssl', 'run the TestCafe proxy server over the HTTPS protocol') | |||
There was a problem hiding this comment.
.option('--ssl', 'run TestCafe proxy server over the HTTPS protocol')Maybe we should rename the flag to --https considering the description?
There was a problem hiding this comment.
No. Need to change description.
This flag contains ssl options that will passed for https server creation.
Also, this option has same name (ssl) for the widely known http-server module.
Changed description: specify ssl options for starting TestCafe using https protocol
There was a problem hiding this comment.
specify ssl options
So, you can actually specify some options after this flag? Which options?
There was a problem hiding this comment.
Yes, you ca specify a lot of options (all options from https server options and parent classes: http server iptions, tls server options).
See a simple example in #1985 (comment)
There was a problem hiding this comment.
Cool!
As far as I understand, options are not required, so we can write
.option('--ssl <options>', 'enable access to TestCafe via the HTTPS protocol and specify SSL options')There was a problem hiding this comment.
.option('--ssl <options>', 'specify SSL options for starting TestCafe proxy server over the HTTPS protocol');There was a problem hiding this comment.
.option('--ssl <options>', 'specify SSL options to run TestCafe proxy server over the HTTPS protocol');
|
❌ Tests for the commit 175d4da have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 175d4da have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 175d4da have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 175d4da have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 175d4da have failed. See details: |
|
❌ Tests for the commit 831fa31 have failed. See details: |
|
@testcafe-build-bot retest |
|
✅ Tests for the commit 831fa31 have passed. See details: |
src/cli/parse-ssl-options.js
Outdated
| value = convertToBestFitType(value); | ||
|
|
||
| if (FILE_OPTION_NAMES.includes(key) && value.length < MAX_PATH_LENGTH) | ||
| value = fs.readFileSync(value); |
There was a problem hiding this comment.
On Linux MAX_PATH_LENGTH is 4096 (4kB). My SSH private key is about 1.5kB. If I pass my certificate, I will get an error from fs.readFileSync. We should check if the file exists, and if it don't, also assume that value is a buffer.
src/cli/parse-ssl-options.js
Outdated
| import fs from 'fs'; | ||
| import os from 'os'; | ||
|
|
||
| const MAX_PATH_LENGTH = os.type() === 'Windows_NT' ? 260 : Infinity; |
There was a problem hiding this comment.
MAX_PATH_LENGTH === Infinity means you can't pass a certificate content for properties that accept both file paths and file contents.
|
✅ Tests for the commit e800581 have passed. See details: |
|
ping @VasilyStrelyaev |
|
❌ Tests for the commit 37e9f98 have failed. See details: |
|
@testcafe-build-bot retest |
|
✅ Tests for the commit 37e9f98 have passed. See details: |
…1985) (DevExpress#2540) * implement a possibility to run TestCafe over https * update text * update option description * fix review issues
@AndreyBelym @VasilyStrelyaev