Fix scrolling for negative scroll target coordinates(closes #2148) #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirovboris
approved these changes
Feb 22, 2018
|
✅ Tests for the commit 96740ef have passed. See details: |
|
❌ Tests for the commit ffce348 have failed. See details: |
src/errors/test-run/templates.js
Outdated
| @@ -198,6 +198,10 @@ export default { | |||
| The "${err.argumentName}" argument specifies an unsupported "${err.actualValue}" device. For a list of supported devices, refer to <a href="http://viewportsizes.com">http://viewportsizes.com</a>. | |||
| `), | |||
|
|
|||
| [TYPE.actionInvalidScrollTargetError]: err => markup(err, ` | |||
| Unable to scroll to the specified point of the element, because a point with the specified ${err.properties} is not inside the element's cropping region. | |||
There was a problem hiding this comment.
Let @VasilyStrelyaev check the text, if it's not done yet
There was a problem hiding this comment.
Unable to scroll to the specified point because a point with the specified ${err.properties} is not located inside the element's cropping region.
VasilyStrelyaev
requested changes
Feb 26, 2018
src/errors/test-run/templates.js
Outdated
| @@ -198,6 +198,10 @@ export default { | |||
| The "${err.argumentName}" argument specifies an unsupported "${err.actualValue}" device. For a list of supported devices, refer to <a href="http://viewportsizes.com">http://viewportsizes.com</a>. | |||
| `), | |||
|
|
|||
| [TYPE.actionInvalidScrollTargetError]: err => markup(err, ` | |||
| Unable to scroll to the specified point of the element, because a point with the specified ${err.properties} is not inside the element's cropping region. | |||
There was a problem hiding this comment.
Unable to scroll to the specified point because a point with the specified ${err.properties} is not located inside the element's cropping region.
kirovboris
approved these changes
Feb 26, 2018
VasilyStrelyaev
approved these changes
Feb 26, 2018
|
❌ Tests for the commit edc423f have failed. See details: |
|
✅ Tests for the commit edc423f have passed. See details: |
helen-dikareva
approved these changes
Feb 26, 2018
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @helen-dikareva @kirovboris