Start browsers with clean profile by default #1792
Conversation
| if (config.path) | ||
| firefoxInfo = await browserTools.getBrowserInfo(config.path); | ||
| else | ||
| firefoxInfo = await browserTools.getBrowserInfo(browserName); |
There was a problem hiding this comment.
firefoxInfo = await browserTools.getBrowserInfo(config.path || browserName);| return match && match !== '0' && match !== 'false'; | ||
| } | ||
|
|
||
| export function useSystemProfile (array) { |
There was a problem hiding this comment.
it seems this is redundant
|
|
||
|
|
||
| const HEADLESS_DEFAULT_WIDTH = 1280; | ||
| const HEADLESS_DEFAULT_HEIGHT = 800; | ||
|
|
||
| const CONFIG_TERMINATOR_RE = /(\s+|^)-/; | ||
| const MODES_LIST = ['userProfile', 'headless', 'emulation']; |
There was a problem hiding this comment.
I feel MODE_LIST is more correctly.
But maybe it's more appropriate to use AVAILABLE_MODES here
| return result; | ||
| } | ||
|
|
||
| export function getPathFromParsedModes (modesList, possibleModes = []) { |
There was a problem hiding this comment.
I'd like to use modes, availableModes = [] here
There was a problem hiding this comment.
modes, availableModes = []
|
|
||
|
|
||
| const CONFIG_TERMINATOR_RE = /(\s+|^)-/; | ||
| const SYSTEM_PROFILE_OPTION_RE = /^useSystemProfile=(.*)$/; |
There was a problem hiding this comment.
We've changed it to userProfile? Am I right?
|
❌ Tests for the commit 7ca7b33 have failed. See details: |
|
❌ Tests for the commit 031e55a have failed. See details: |
| return result; | ||
| } | ||
|
|
||
| export function getPathFromParsedModes (modesList, possibleModes = []) { |
There was a problem hiding this comment.
modes, availableModes = []
| return path; | ||
| } | ||
|
|
||
| export function getModes (modesList, availableModes = []) { |
There was a problem hiding this comment.
modes, availableModes = []
|
❌ Tests for the commit 031e55a have failed. See details: |
AndreyBelym
force-pushed
the
clean-browser-profiles
branch
from
031e55a
to
8c6d128
Compare
\cc @AlexanderMoskovkin @miherlosev
closes #1623