Implement uniform URL for connecting remote browsers (closes #1476) #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 9f8d92c have failed. See details: |
|
❌ Tests for the commit 1723c83 have failed. See details: |
|
❌ Tests for the commit ffbc6eb have failed. See details: |
1 similar comment
|
❌ Tests for the commit ffbc6eb have failed. See details: |
|
✅ Tests for the commit ffbc6eb have passed. See details: |
AlexanderMoskovkin
approved these changes
May 18, 2017
alcazaco
reviewed
May 25, 2017
src/cli/remotes-wizard.js
Outdated
|
|
||
| if (remoteCount) { | ||
| log.hideSpinner(); | ||
|
|
||
| var description = dedent(` | ||
| Connecting ${remoteCount} remote browser(s)... | ||
| Navigate to the appropriate URL from each of the remote browsers. | ||
| Navigate to the following URL from each of the remote browsers. |
There was a problem hiding this comment.
Navigate to the following URL from each remote browser.
|
✅ Tests for the commit 87ad77a have passed. See details: |
|
FPR |
AlexanderMoskovkin
approved these changes
May 25, 2017
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\сс @AlexanderMoskovkin