[docs] Describe adding custom methods to selector #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churkin
suggested changes
Mar 20, 2017
|
|
||
| ```js | ||
| const myTable = Selector('.my-table').addCustomMethods({ | ||
| getCellText: (table, rowIndex, columnIndex) => { |
There was a problem hiding this comment.
getCellText: (table, rowIndex, columnIndex) => table.rows[rowIndex].cells[columnIndex].innerTextThere was a problem hiding this comment.
I don't like horizontal scroll bars below the code
There was a problem hiding this comment.
You can start it from new line
There was a problem hiding this comment.
getCellText: (table, rowIndex, columnIndex) =>
table.rows[rowIndex].cells[columnIndex].innerTextI like it more
inikulin
reviewed
Mar 20, 2017
| } | ||
| }); | ||
|
|
||
| await myTable.getCellText(2,5); |
There was a problem hiding this comment.
It would be nice to show usage of that in assertions
|
FPR |
inikulin
suggested changes
Mar 20, 2017
| @@ -38,7 +38,9 @@ This topic contains the following sections. | |||
| * [Define Action Targets](#define-action-targets) | |||
| * [Define Assertion Actual Value](#define-assertion-actual-value) | |||
| * [Selector Timeout](#selector-timeout) | |||
| * [Adding Custom Properties to Element State](#adding-custom-properties-to-element-state) | |||
| * [Adding Custom Properties and Methods to the Element State](#adding-custom-properties-and-methods-to-the-element-state) | |||
There was a problem hiding this comment.
Extending selectors maybe?
churkin
approved these changes
Mar 20, 2017
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
* [docs] Describe adding custom methods to selector * Add assertion to an example * Use arrow function in an example * Change section name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @DevExpress/testcafe-docs