Fix fails on ES6 method syntax in ClientFunction arguments (closes #1279) #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMoskovkin
approved these changes
Mar 1, 2017
|
✅ Tests for the commit 404633b have passed. See details: |
kirovboris
requested changes
Mar 1, 2017
| @@ -7,6 +7,7 @@ import { ClientFunctionAPIError } from '../../errors/runtime'; | |||
| import MESSAGE from '../../errors/runtime/message'; | |||
|
|
|||
| const ANONYMOUS_FN_RE = /^function\*?\s*\(/; | |||
| const ES6_OBJ_METHOD_NAME_RE = /^([A-Za-z\*\$]+)\s*\(/; | |||
There was a problem hiding this comment.
It seems this regex too weak for function name, e.g. you can use _ or numbers.
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 8216927 have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 8216927 have failed. See details: |
|
✅ Tests for the commit 8216927 have passed. See details: |
kirovboris
approved these changes
Mar 2, 2017
AlexanderMoskovkin
approved these changes
Mar 2, 2017
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…vExpress#1279) (DevExpress#1280) * Fix fails on ES6 method syntax in ClientFunction arguments (closes DevExpress#1279) * Fix ES6 method determination * Use other solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @kirovboris @AndreyBelym @AlexanderMoskovkin