Changed babel options to avoid extra lines in report (closes #1226) #1236
Conversation
|
It won't work, re-export still broken. |
|
❌ Tests for the commit 74d0344 have failed. See details: |
|
Asked for help on Babel forum. Anyway, i'm still working on it. |
georgiy-abbasov
force-pushed
the
gh-1226
branch
from
4fe4248
to
8603d49
Compare
|
❌ Tests for the commit 8603d49 have failed. See details: |
georgiy-abbasov
changed the title
|
❌ Tests for the commit 219fe15 have failed. See details: |
|
Seems like approach from 8603d49 worked, why not stick with it? |
|
❌ Tests for the commit 5e0f21d have failed. See details: |
|
@testcafe-build-bot \retest |
|
@inikulin, i've got some problems with promises in server tests on v0.10 |
|
❌ Tests for the commit 5e0f21d have failed. See details: |
|
@georgiy-abbasov We can enable polyfills for node 10 it's not a big deal: we'll have problem with callsites on node 10, but it's already in maintenance mode and we're about to drop support for it. |
|
@inikulin, ok, we can do it, but it seems, that last approach works too. |
|
@georgiy-abbasov hmm, didn't see the last one. Looks good if it works |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit 5e0f21d have failed. See details: |
2 similar comments
|
❌ Tests for the commit 5e0f21d have failed. See details: |
|
❌ Tests for the commit 5e0f21d have failed. See details: |
|
✅ Tests for the commit 5e0f21d have passed. See details: |
georgiy-abbasov
changed the title
|
FPR |
test/server/compiler-test.js
Outdated
| }); | ||
|
|
||
| it('Incorrect callsite stack in error report if "import" is used (GH-1226)', function () { | ||
| this.timeout(5000); |
There was a problem hiding this comment.
we can remove the timeout here because it's defined at the top-level
|
✅ Tests for the commit f9b2659 have passed. See details: |
…ss#1226) (DevExpress#1236) * Changed babel options to avoid extra lines in report (closes DevExpress#1226) * Approach changed, added regression test for DevExpressgh-969 * another one approach * One more approach * Remarks fixed
\cc @inikulin, @AlexanderMoskovkin